Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: graphiql introspection bug with <graphql@16 servers #2087

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

acao
Copy link
Member

@acao acao commented Dec 6, 2021

I think this will fix #2085

provides a prop for inputValueDeprecation when invoking getIntrospectionQuery() to avoid causing issues with graphql servers who do not yet support this introspection option

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2021

🦋 Changeset detected

Latest commit: 74fbe02

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphiql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

The latest changes of this PR are available as canary in npm (based on the declared changesets):

@acao acao force-pushed the fix/introspection-query-bug branch from 13bfee8 to 06a4af7 Compare December 6, 2021 13:31
@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #2087 (74fbe02) into main (2d91916) will decrease coverage by 2.38%.
The diff coverage is 66.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2087      +/-   ##
==========================================
- Coverage   65.70%   63.32%   -2.39%     
==========================================
  Files          85       79       -6     
  Lines        5106     5279     +173     
  Branches     1631     1665      +34     
==========================================
- Hits         3355     3343      -12     
- Misses       1747     1932     +185     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/components/QueryEditor.tsx 63.96% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
...kages/graphiql/src/utility/introspectionQueries.ts 100.00% <ø> (ø)
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf1073...74fbe02. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

@acao acao force-pushed the fix/introspection-query-bug branch from 06a4af7 to 4d43589 Compare December 6, 2021 13:32
@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview December 6, 2021 13:34 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview December 6, 2021 13:34 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview December 6, 2021 13:35 Inactive
@acao acao force-pushed the fix/introspection-query-bug branch from 4d43589 to 74fbe02 Compare December 6, 2021 14:47
@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview December 6, 2021 14:50 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview December 6, 2021 14:50 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview December 6, 2021 14:50 Inactive
@acao acao merged commit 45a9075 into main Dec 6, 2021
@acao acao deleted the fix/introspection-query-bug branch December 6, 2021 14:51
This was referenced Dec 6, 2021
jkimbo added a commit to strawberry-graphql/strawberry that referenced this pull request Feb 19, 2023
Version 1.5.10 of GraphiQL ([ref](graphql/graphiql#2087))
disabled introspection for deprecated arguments because it wasn't supported by all GraphQL server versions.
This PR enables it so that deprecated arguments show up again in
GraphiQL.

Fixes: #2532
Diff-Id: 40d03
patrick91 pushed a commit to strawberry-graphql/strawberry that referenced this pull request Feb 19, 2023
Version 1.5.10 of GraphiQL ([ref](graphql/graphiql#2087))
disabled introspection for deprecated arguments because it wasn't supported by all GraphQL server versions.
This PR enables it so that deprecated arguments show up again in
GraphiQL.

Fixes: #2532
Diff-Id: 40d03
erikwrede pushed a commit to erikwrede/strawberry that referenced this pull request Feb 23, 2023
Version 1.5.10 of GraphiQL ([ref](graphql/graphiql#2087))
disabled introspection for deprecated arguments because it wasn't supported by all GraphQL server versions.
This PR enables it so that deprecated arguments show up again in
GraphiQL.

Fixes: strawberry-graphql#2532
Diff-Id: 40d03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IntrospectionQuery fails, unable to run graphiql
1 participant