Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include deprecated arguments in GraphiQL #2575

Merged
merged 1 commit into from
Feb 19, 2023

Conversation

jkimbo
Copy link
Member

@jkimbo jkimbo commented Feb 19, 2023

Description

Version 1.5.10 of GraphiQL (ref) disabled introspection for deprecated arguments because it wasn't supported by all GraphQL server versions. This PR enables it so that deprecated arguments show up again in GraphiQL.

Fixes: #2532

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Version 1.5.10 of GraphiQL ([ref](graphql/graphiql#2087))
disabled introspection for deprecated arguments because it wasn't supported by all GraphQL server versions.
This PR enables it so that deprecated arguments show up again in
GraphiQL.

Fixes: #2532
Diff-Id: 40d03
Copy link
Member

@patrick91 patrick91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Merging #2575 (a4322a4) into main (9eafe5b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2575   +/-   ##
=======================================
  Coverage   96.30%   96.30%           
=======================================
  Files         184      184           
  Lines        7571     7571           
  Branches     1394     1394           
=======================================
  Hits         7291     7291           
  Misses        179      179           
  Partials      101      101           

@botberry
Copy link
Member

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:


Version 1.5.10 of GraphiQL disabled introspection for deprecated
arguments because it wasn't supported by all GraphQL server versions.
This PR enables it so that deprecated arguments show up again in
GraphiQL.


Here's the preview release card for twitter:

Here's the tweet text:

🆕 Release (next) is out! Thanks to Jonathan Kim for the PR 👏

Get it here 👉 https://github.com/strawberry-graphql/strawberry/releases/tag/(next)

@patrick91 patrick91 merged commit 91f2813 into main Feb 19, 2023
@patrick91 patrick91 deleted the include-deprecated-args-graphiql branch February 19, 2023 15:23
erikwrede pushed a commit to erikwrede/strawberry that referenced this pull request Feb 23, 2023
Version 1.5.10 of GraphiQL ([ref](graphql/graphiql#2087))
disabled introspection for deprecated arguments because it wasn't supported by all GraphQL server versions.
This PR enables it so that deprecated arguments show up again in
GraphiQL.

Fixes: strawberry-graphql#2532
Diff-Id: 40d03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecated arguments no longer appear in introspection query but execute successfully
3 participants