add useResponseEditor hook to @graphiql/react
#2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 81cd37a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## main #2411 +/- ##
==========================================
+ Coverage 65.70% 68.17% +2.46%
==========================================
Files 85 76 -9
Lines 5106 4754 -352
Branches 1631 1558 -73
==========================================
- Hits 3355 3241 -114
+ Misses 1747 1509 -238
Partials 4 4
Continue to review full report at Codecov.
|
packages/graphiql-react/src/editor/components/image-preview.tsx
Outdated
Show resolved
Hide resolved
thomasheyenbrock
force-pushed
the
feat/result-editor-to-context
branch
from
33b32ee to
81cd37a
Compare
|
The latest changes of this PR are not available as canary, since there are no linked |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves over the logic for the last (read-only) editor: The response editor. We also move the
ImagePreviewcomponent to@graphiql/reactas it's only used in theuseResponseEditorhook. This allows us to remove the utilities fromgraphiqlthat have been temporarily copied over in #2404 (commonKeys,importCodeMirror) as well as theCodeMirrorSizerutility (each editor takes care of resizing itself now using theuseResizeEditorhook).