Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #2403

Merged
merged 1 commit into from
May 22, 2022
Merged

Version Packages #2403

merged 1 commit into from
May 22, 2022

Conversation

acao
Copy link
Member

@acao acao commented May 13, 2022

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

[email protected]

Minor Changes

  • #2412 c2e2f53d Thanks @thomasheyenbrock! - Move QueryStore from graphiql package to @graphiql/toolkit

  • #2412 c2e2f53d Thanks @thomasheyenbrock! - Move HistoryStore from graphiql package to @graphiql/toolkit

  • #2409 f2025ba0 Thanks @thomasheyenbrock! - Move the logic of the variable editor from the graphiql package into a hook useVariableEditor provided by @graphiql/react

  • #2408 d825bb75 Thanks @thomasheyenbrock! - Move the logic of the query editor from the graphiql package into a hook useQueryEditor provided by @graphiql/react

  • #2411 ad448693 Thanks @thomasheyenbrock! - Move the logic of the result viewer from the graphiql package into a hook useResponseEditor provided by @graphiql/react

  • #2370 7f695b10 Thanks @thomasheyenbrock! - Include the context provider for the explorer from @graphiql/react and replace the local state for the nav stack of the docs with methods provided by hooks from @graphiql/react.

  • #2412 c2e2f53d Thanks @thomasheyenbrock! - Move StorageAPI from graphiql package to @graphiql/toolkit

  • #2404 029ddf82 Thanks @thomasheyenbrock! - Add a context provider for editors and move the logic of the headers editor from the graphiql package into a hook useHeaderEditor provided by @graphiql/react

Patch Changes

@graphiql/[email protected]

Minor Changes

  • #2409 f2025ba0 Thanks @thomasheyenbrock! - Move the logic of the variable editor from the graphiql package into a hook useVariableEditor provided by @graphiql/react

  • #2408 d825bb75 Thanks @thomasheyenbrock! - Move the logic of the query editor from the graphiql package into a hook useQueryEditor provided by @graphiql/react

  • #2411 ad448693 Thanks @thomasheyenbrock! - Move the logic of the result viewer from the graphiql package into a hook useResponseEditor provided by @graphiql/react

  • #2404 029ddf82 Thanks @thomasheyenbrock! - Add a context provider for editors and move the logic of the headers editor from the graphiql package into a hook useHeaderEditor provided by @graphiql/react

Patch Changes

@graphiql/[email protected]

Minor Changes

Patch Changes

  • #2407 bc3dc64c Thanks @benjdlambert! - Move graphql-ws dependency to a dynamic import, and add a nice error message when it's not installed

[email protected]

Patch Changes

[email protected]

Patch Changes

[email protected]

Patch Changes

@acao
Copy link
Member Author

acao commented May 13, 2022

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #2403 (b59af02) into main (2d91916) will decrease coverage by 0.64%.
The diff coverage is 69.20%.

❗ Current head b59af02 differs from pull request most recent head 68c8c5a. Consider uploading reports for the commit 68c8c5a to get more accurate results

@@            Coverage Diff             @@
##             main    #2403      +/-   ##
==========================================
- Coverage   65.70%   65.06%   -0.65%     
==========================================
  Files          85       81       -4     
  Lines        5106     5255     +149     
  Branches     1631     1698      +67     
==========================================
+ Hits         3355     3419      +64     
- Misses       1747     1832      +85     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ackages/codemirror-graphql/src/utils/info-addon.ts 1.02% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
...aphiql/src/components/DocExplorer/DefaultValue.tsx 50.00% <ø> (ø)
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ca6a92...68c8c5a. Read the comment docs.

@github-actions github-actions bot force-pushed the changeset-release/main branch 3 times, most recently from e6899fb to a7e7edc Compare May 18, 2022 07:55
@thomasheyenbrock
Copy link
Collaborator

thomasheyenbrock commented May 18, 2022

⚠️ Merging this is blocked currently, I found a bug introduced in #2404 that I'm going to fix first!

@github-actions github-actions bot force-pushed the changeset-release/main branch 4 times, most recently from 95b5827 to 37d11fb Compare May 21, 2022 11:52
@acao
Copy link
Member Author

acao commented May 22, 2022

@thomasheyenbrock is it going to be an issue when I cut these releases? We will need to merge very soon for the LSP server and vscode graphql

@github-actions github-actions bot force-pushed the changeset-release/main branch from 37d11fb to 68c8c5a Compare May 22, 2022 06:18
@acao
Copy link
Member Author

acao commented May 22, 2022

@thomasheyenbrock in a manual regression experiment, the latest netlify deploy from the last merge is looking great
Screenshot 2022-05-22 at 09 46 29

awesome working adding context support so gradually! so many exciting capabilities this will unlock!

@acao acao merged commit 2832e04 into main May 22, 2022
@acao acao deleted the changeset-release/main branch May 22, 2022 07:48
@acao
Copy link
Member Author

acao commented May 22, 2022

can I ask @thomasheyenbrock what made these minor changes? was there any API breaking changes (props?) or just new features?

@thomasheyenbrock
Copy link
Collaborator

thomasheyenbrock commented May 22, 2022

I did a minor version for @graphiql/toolkit and @graphiql/react since they obviously got new stuff. I also did a minor bump for graphiql because it's a more fundamental change in terms of the functionality under the hood. I know that a lot of folks merge in patch updates automatically without looking at them, so my hope was to create an incentive for giving this a closer look before upgrading to maybe catch unexpected bugs that might have been introduced with these changes.

However, there should not be any breaking changes yet in any package!

@acao
Copy link
Member Author

acao commented May 22, 2022

ok, that's good to know! perhaps this minor version can denote when we officially started using @graphiql/toolkit and @graphiql/react. this would be the most visible change to users who aren't looking into or using internals.

if anyone starts complaining about window.GraphiQL.<some method> no longer working or other internal changes, they are already using an internal and unsupported interface! However, in these cases, we should consider what they were using it for, and how they might solve that problem differently.

Also, if we are at any point adding/removing any library exports (at the main/module export level), these should be considered non-internal API functions & components, and a minor version could denote a breaking change in one of these lesser-used interfaces as well. For example, there are a number of consumers of the legacy DocExplorer and/or it's components (thus the inspiration for @graphiql/react), these should be considered supported usages, and thus props-level or other interface changes should be considered at least minor version changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants