Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix persisting headers in tab state #2418

Merged
merged 1 commit into from
May 21, 2022

Conversation

thomasheyenbrock
Copy link
Collaborator

The logic for persisting headers in tabs was exactly switched, i.e. we stripped headers when shouldPersistHeaders was true. This also caused GraphiQL to open duplicate tabs when the headers prop was used: #2380

@changeset-bot
Copy link

changeset-bot bot commented May 21, 2022

🦋 Changeset detected

Latest commit: 3606924

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphiql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #2418 (3606924) into main (2d91916) will increase coverage by 2.45%.
The diff coverage is 71.52%.

@@            Coverage Diff             @@
##             main    #2418      +/-   ##
==========================================
+ Coverage   65.70%   68.16%   +2.45%     
==========================================
  Files          85       75      -10     
  Lines        5106     4702     -404     
  Branches     1631     1547      -84     
==========================================
- Hits         3355     3205     -150     
+ Misses       1747     1493     -254     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql-react/src/editor/whitespace.ts 100.00% <ø> (ø)
packages/graphiql-toolkit/src/storage/query.ts 36.73% <ø> (ø)
... and 91 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e2f53...3606924. Read the comment docs.

@thomasheyenbrock thomasheyenbrock merged commit 6d7fb6e into graphql:main May 21, 2022
@thomasheyenbrock thomasheyenbrock deleted the issues/2380 branch May 21, 2022 11:49
@acao acao mentioned this pull request May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant