Typo in new timer code

[dresco]

Just noticed this while merging latest changes into H7 driver..

STM32F7xx/Src/timers.c

Lines 313 to 317 in 8ccfaa0

	#ifdef TIM7
	case (uint32_t)TIM14:
	__HAL_RCC_TIM14_CLK_ENABLE();
	break;
	#endif

[dresco]

Also, seeing a hardfault during the port claiming process when an aux out port is not pwm capable, execution gets to the return statement of pwm_is_available() with pwm still NULL;

STM32F7xx/Src/pwm.c

Line 119 in 8ccfaa0

return !timer_is_claimed(pwm->timer);

[dresco]

Hi Terje, just wanted to query that pwm.c fix (haven't tried it yet)..

return pwm && !timer_is_claimed(pwm->timer);

Won't pwm->timer get dereferenced anyway, even if pwm is null?

I was hitting the hardfault on some build configurations but not others, so my suspicion was that pwm->timer was pointing to an invalid memory address depending on compile options.

[terjeio]

Won't pwm->timer get dereferenced anyway, even if pwm is null?

No, it should not.

[dresco]

No, it should not.

Cool, thanks! Never knew that was a defined behaviour...