Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Clean up packaging & installation pipeline #6687

Merged
merged 2 commits into from
Jan 3, 2023

Conversation

cdkini
Copy link
Contributor

@cdkini cdkini commented Jan 3, 2023

Changes proposed in this pull request:

  • Remove outdated refs to main
  • Ensure we're running on latest develop (should match the same cron job as our primary async pipeline)

Definition of Done

@netlify
Copy link

netlify bot commented Jan 3, 2023

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 6cbc078
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/63b44713aeee0d0008929bb6
😎 Deploy Preview https://deploy-preview-6687--niobium-lead-7998.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ghost
Copy link

ghost commented Jan 3, 2023

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

- main
exclude:
- develop

# The pipeline is run under two primary conditions: if merging into main or as scheduled by the above cron job.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably just remove this comment as well

@cdkini cdkini merged commit 3803ebf into develop Jan 3, 2023
@cdkini cdkini deleted the m/great-1504/clean_up_packaging_pipeline branch January 3, 2023 15:17
Shinnnyshinshin pushed a commit that referenced this pull request Jan 3, 2023
* develop:
  [MAINTENANCE] Misc updates to dev Azure pipeline (#6686)
  [MAINTENANCE] Clean up packaging & installation pipeline (#6687)
  [MAINTENANCE] Partial test linting (#6679)
  [MAINTENANCE] Clean up returns style and type hints in CardinalityChecker utility (#6677)
  [MAINTENANCE] Don't attempt any regex Expectation tests with snowflake (#6672)
Shinnnyshinshin pushed a commit that referenced this pull request Jan 3, 2023
* develop:
  [MAINTENANCE] Cleanup typing errors. (#6691)
  [FEATURE] Support to include ID/PK in validation result for each row - Spark (#6676)
  [MAINTENANCE] Get datetime tests working for trino/snowflake/spark in values_to_be_in_set (#6671)
  [MAINTENANCE] Update `get_context` return type (#6684)
  [MAINTENANCE] `mypy` typing for `core/util.py` (#6617)
  [MAINTENANCE] Misc updates to dev Azure pipeline (#6686)
  [MAINTENANCE] Clean up packaging & installation pipeline (#6687)
  [MAINTENANCE] Partial test linting (#6679)
  [MAINTENANCE] Clean up returns style and type hints in CardinalityChecker utility (#6677)
  [MAINTENANCE] Don't attempt any regex Expectation tests with snowflake (#6672)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants