[MAINTENANCE] Cleanup typing errors. #6691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
👇 Click on the image for a new way to code review
Legend |
Kilo59
reviewed
Jan 3, 2023
Kilo59
reviewed
Jan 3, 2023
anthonyburdi
reviewed
Jan 3, 2023
| _default_header = "" | ||
|
|
||
| _default_content_block_styling = {"classes": ["col-12"]} | ||
| _default_content_block_styling: Dict[str, JSONValues] = {"classes": ["col-12"]} |
There was a problem hiding this comment.
Just a question to help me understand better - is the reason that this is typed with Dict[str, JSONValues] and not just JSONValues because we know that it has str keys at the top level?
Kilo59
reviewed
Jan 3, 2023
Kilo59
reviewed
Jan 3, 2023
| "expect_column_min_to_be_between", | ||
| ]: | ||
| new_block = TextContent(**{"content_block_type": "text", "text": []}) | ||
| new_block["content"].append( |
There was a problem hiding this comment.
We determined this was dead code.
TextContentdoesn't implement__getitem__, so this would break._render_unrecognizedis never called anywhere in the codebase.
Shinnnyshinshin
pushed a commit
that referenced
this pull request
Jan 3, 2023
* develop: [MAINTENANCE] Cleanup typing errors. (#6691) [FEATURE] Support to include ID/PK in validation result for each row - Spark (#6676) [MAINTENANCE] Get datetime tests working for trino/snowflake/spark in values_to_be_in_set (#6671) [MAINTENANCE] Update `get_context` return type (#6684) [MAINTENANCE] `mypy` typing for `core/util.py` (#6617) [MAINTENANCE] Misc updates to dev Azure pipeline (#6686) [MAINTENANCE] Clean up packaging & installation pipeline (#6687) [MAINTENANCE] Partial test linting (#6679) [MAINTENANCE] Clean up returns style and type hints in CardinalityChecker utility (#6677) [MAINTENANCE] Don't attempt any regex Expectation tests with snowflake (#6672)
jcampbell
pushed a commit
that referenced
this pull request
Jan 11, 2023
Co-authored-by: Gabriel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR from mob typing session.