-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
corrections for russian translation #848
Conversation
I have not completely finished. but I wasn't sure how to save
Corrections for russian translation#1
src/_locales/ru/messages.json
Outdated
"html_updated_info_line1": { "message": "Сделан автоматически бэкап перед обновлением." }, | ||
"html_updated_info_line2_prefix": { "message": "Если есть проблемы с обновлением, то Вы можете восстановить потерянные вкладки из бэкапа: " }, | ||
"html_updated_info_line1": { "message": "Перед обновлением была сделана резервная копия ваших вкладок." }, | ||
"html_updated_info_line2_prefix": { "message": "Если возникнут проблемы с обновлением, то Вы сможете восстановить потерянные вкладки из резервной копии: " }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This message I guess we can only see right before Chrome Web Store TGS version gets updated, so here @deanoemcke's help may also be needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you open the extension settings page, and change the url from options.html to updated.html you'll see this screen.
The ...line2_prefix text is for the text before the 'session management' link.
The ...line2_suffix text is for after that link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aww yes, this message appears AFTER the update, not before, so "html_updated_info_line2_prefix" might need to be like:
"Если возникли проблемы с обновлением, то Вы можете восстановить потерянные вкладки из резервной копии в разделе '"
and "html_updated_info_line2_suffix" like:
"'."
Soo that live it looks like:
Если возникли проблемы с обновлением, то Вы можете восстановить потерянные вкладки из резервной копии в разделе 'Управление сессиями'.
Where "Управление сессиями" is the "session management" link.
And I'm not sure whether "Управление сессиями" will start with the capital letter "У" or not ("у"). Coz if it's small "у" then I guess there's no need for ' around.
Also I would recommend to check translation that all russian "Вы", "Вас", "Ваш", etc, start with capital "В", so it all looks unified in showing user some "respect".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deanoemcke
I get a slightly different message. for some reason, the messages are different, in version 160 there is text from version 109, which is no longer used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In any case, I corrected all the errors regarding this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MonsterNya well messages r different probably coz a lot has changed since 109 version, but I can't get about which no longer used text r u talking here? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MonsterNya saw ur final variant, I think "html_updated_info_line2_prefix" at least should be like:
"Если во время обновления возникли проблемы, то Вы можете восстановить потерянные вкладки из резервной копии в разделе "
if not my previous variant then smth like that, coz it's not after, it's during the update (as it said in the original) user may encounter problems..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jollfye
well, if so in the original, let it be "во время". variant "с обновлением" was more suitable for tools to solve update problems than tab loss.
fixed
src/_locales/ru/messages.json
Outdated
"html_options_suspend_discard_after_suspend_tooltip_line2a": { "message": "Однако, это может также привести к небольшой задержке отображения при выборе" }, | ||
"html_options_suspend_no_active_tabs": { "message": "Никогда не приостанавливать активную вкладку в каждом окне" }, | ||
"html_options_suspend_automatically_unsuspend": { "message": "Автоматически возобновлять приостановленную вкладку при переключении" }, | ||
"html_options_suspend_discard_after_suspend": { "message": "Использовать встроенный в Chrome механизм экономии памяти при приостановке вкладки" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
about the work of tab-discarding. Does it start to work when I put a tab to sleep? or does it work anytime for a tab that sleeps?
p.s. By sleep, I mean suspend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't get the difference between these two questions, can u please explain? Why u asked them? What do u think may be not correct here, at which line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 78.
it can be translated as
Использовать встроенный в Chrome механизм экономии памяти при приостановке вкладки
or
Использовать встроенный в Chrome механизм экономии памяти для приостановленных вкладок
However, in practice, I see a delay in rendering only for non-suspend tabs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second variant I think would be better, coz this discarding mechanism works for all tabs as in general for as I can understand now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it works with all tabs, as I can see, then
Использовать встроенный в Chrome механизм экономии памяти
then need to rewrite the entire description of the tab-discarding. however, the original is specifically mentioned "Reduces a suspended tab's memory usage"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact is that as far as I can understand, tab-discarding works ONLY with WORKING tabs (which TGS has NOT suspended).
here (chrome://discards/) i can forcibly give the tab the desired flag, and if i assign flag "discard" to the suspended tab, then as soon as I switch to it, I find that tab-discarding took control (TGS loses control). and tab resumed work, as if this tab was not previously suspended
p.s. uh, i hope you understand what i mean
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't assign or use on a suspended tab discard action, only load, coz they'r already discarded, coz I have TGS option "Apply Chrome's built-in memory-saving when suspending" enabled and it works. I think discarding works for all tabs if enabled including TGS suspended ones. If discarding disabled in TGS options, suspended tabs just hang in Chrome Task manager (consuming some memory), otherwise they'r not, only active suspended tab does before I unsuspend it and it becomes the usual active tab or just loaded if lost focus. Can't get what u r talking bout, sorry, but if u have a better translation variant, let's review it, and I guess we also may need dev @deanoemcke's help in understanding how it all works here with this one phrase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MonsterNya This option will discard tabs AFTER they have been suspended. So it CAN discard suspended tabs. When you revisit one of the suspended discarded tabs, it will undiscard automatically, showing the suspended tab in it's place. This is where you get the rendering delay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MonsterNya So the second variant does sound better after all:
"Использовать встроенный в Chrome механизм экономии памяти для приостановленных вкладок"
Also I would make some little changes to ur final tab-discarding description, I'll comment them below. There's no need to rewrite it completely, it's almost fine now. Even if in English we r talking bout a single suspended tab's memory usage which then comes to 500% memory savings in general, in russian we can start talk plural right from the option line here and continue to its description in tooltip, I guess it makes understanding easier, no talks bout single tab then bout them all, it's all, right from the beginning, so less thinking (stepping from single to plural) on user's end 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, we figured it out =)
src/_locales/ru/messages.json
Outdated
@@ -169,26 +169,26 @@ | |||
"html_suspended_modal_this_domain": { "message": "этот домен" }, | |||
"html_suspended_modal_this_page": { "message": "эту страницу" }, | |||
"html_suspended_modal_temp_whitelist": { "message": "Только эту вкладку в текущей сессии" }, | |||
"html_suspended_modal_temp_whitelist_notice": { "message": "вы всё ещё можете приостановить вручную." }, | |||
"html_suspended_modal_temp_whitelist_notice": { "message": "Вы все еще сможете приостановить вручную." }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also can't find this phrase live, I guess we may need @deanoemcke's help
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, the html_suspended_modal
has been removed. You can probably ignore these ones. I'll try to remove these old translations once we've merged your PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, ignore mod on ^____^
src/_locales/ru/messages.json
Outdated
"html_permissions_info": { "message": "У расширения в данный момент нет разрешения приостанавливать вкладки с URL (адресами), начинающимися со слова \"file\".\nЧтобы это изменить, включите \"Разрешить открывать локальные файлы по ссылкам\" со страницы настроек расширения." }, | ||
"html_permissions_backup": { "message": "Примечание: изменение этой опции приведет к временному исчезновению всех приостановленных вкладок.\nНа всякий случай рекомендуем сделать бэкап (резервную копию) текущей сессии вкладок." }, | ||
"html_permissions_info": { "message": "У расширения в данный момент нет разрешения приостанавливать вкладки с URL-адресами, начинающимися со слова \"file\".\nЧтобы это изменить, включите \"Разрешить открывать локальные файлы по ссылкам\" со страницы настроек расширения." }, | ||
"html_permissions_backup": { "message": "Примечание: изменение этой опции приведет к временному исчезновению всех приостановленных вкладок.\nНа всякий случай рекомендуем сделать бэкап (резервную копию) вкладок текущей сессии." }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the word "backup" is made to mean manual copying or using session management? where can i see this message live? maybe you can give me a screenshot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it means both, at the user's discretion, user can just save the current session in session management or can export it to file and save externally, both can be done in session management, so no specification for backup word, but I guess we could add some explanation about where user can make a backup (coz users don't know anything), so it may look like: ..."сделать бэкап (резервную копию) вкладок текущей сессии в Управлении сессиями."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, I corrected, only the preview above is "outdated"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, saw it now, urs variant with word "раздел" even better 👍
src/_locales/ru/messages.json
Outdated
"js_history_confirm_session_overwrite": { "message": "Сессия с таким именем уже существует. Перезаписать?" }, | ||
"js_history_import_fail": { "message": "Ошибка при загрузке файла. Убедитесь, что файл в корректном формате." }, | ||
"js_history_import_fail": { "message": "Ошибка при загрузке файла. Убедитесь, что файл в корректном формате (содежит один URL в каждой строке)." }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rephrase it like this: ..."Убедитесь, что это текстовый файл и он содержит не более одного URL-адреса в каждой строке." Also I shell recommend u to check the whole ur translation in MS Word so there's no simple errors like that in word "содежит" above 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
p.s. oh yeah, i forgot to do it
src/_locales/ru/messages.json
Outdated
@@ -37,15 +37,15 @@ | |||
"html_about_html2canvas_prefix": { "message": "Это расширение использует" }, | |||
"html_about_html2canvas_suffix": { "message": "библиотеку Niklas von Hertzen." }, | |||
"html_about_indexedDb": { "message": "db.js" }, | |||
"html_about_indexedDb_prefix": { "message": "Также используется обёртка indexedDb " }, | |||
"html_about_indexedDb_prefix": { "message": "Также используется обертка indexedDb " }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be like this: "Также используется indexedDb упаковщик ", but I'm not sure what db.js is "обертка" or "упаковщик" in russian
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
due to the specificity of the term and the target audience of this text, can even use "враппер"
https://ru.wikipedia.org/wiki/%D0%92%D1%80%D0%B0%D0%BF%D0%BF%D0%B5%D1%80
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be even better so it'll be like:
"Также используется indexedDb враппер "
and I insist on original "indexedDb wrapper db.js" words sequence coz of adequate reasons u said urself above and I agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I completely agree, fixed.
src/_locales/ru/messages.json
Outdated
"html_options_suspend_discard_after_suspend_tooltip_line1c": { "message": "уменьшению использования памяти при работе с большим количеством вкладок." }, | ||
"html_options_suspend_discard_after_suspend_tooltip_line2a": { "message": "Однако, это может также привести к небольшой задержке отображения при выборе" }, | ||
"html_options_suspend_no_active_tabs": { "message": "Никогда не приостанавливать активную вкладку в каждом окне" }, | ||
"html_options_suspend_automatically_unsuspend": { "message": "Автоматически возобновлять вкладку при выделении" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Автоматически возобновлять приостановленную вкладку при переходе на нее"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in my translation
Автоматически возобновлять приостановленную вкладку при переключении
why do i see above
Автоматически возобновлять вкладку при выделении
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I'm not sure, maybe coz I used ur initial commit to comment on, but anyway I recommend the use of "при переходе на нее" instead of "при выделении", more accurate in my view
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last version when opening a commit its "correction#4-1".
I do not like both word (переключение/выделение), yours is better, fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for explanation 😊
src/_locales/ru/messages.json
Outdated
@@ -91,45 +91,45 @@ | |||
"html_options_suspend_screen_capturing_screen_only": { "message": "Захватывать только верх экрана" }, | |||
"html_options_suspend_screen_capturing_entire_page": { "message": "Захватывать всю страницу" }, | |||
"html_options_suspend_screen_capturing_tooltip_line1a": {"message": "На заблокированной вкладке расширение может отображать предварительный просмотр изображения вкладки"}, | |||
"html_options_suspend_screen_capturing_tooltip_line1b": {"message": " как раз перед тем, как она была приостановлена." }, | |||
"html_options_suspend_screen_capturing_tooltip_line2a": {"message": "Функция захвата экрана является экспериментальной и может привести к значительным нагрузке на процессор"}, | |||
"html_options_suspend_screen_capturing_tooltip_line1b": {"message": "как раз перед тем, как она была приостановлена." }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
R u sure space here is unneeded? What if in result it'll look like "вкладкикак", but also not sure, didn't test it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
previous translation again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See now, it's definitely ok to delete space here, thanks for screeny
src/_locales/ru/messages.json
Outdated
@@ -91,45 +91,45 @@ | |||
"html_options_suspend_screen_capturing_screen_only": { "message": "Захватывать только верх экрана" }, | |||
"html_options_suspend_screen_capturing_entire_page": { "message": "Захватывать всю страницу" }, | |||
"html_options_suspend_screen_capturing_tooltip_line1a": {"message": "На заблокированной вкладке расширение может отображать предварительный просмотр изображения вкладки"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better would be if we simplify here a bit: "На приостановленной вкладке расширение может отображать скриншот вкладки"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed this translation, why do not you see the final version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can see now, thanks, urs current variant better
src/_locales/ru/messages.json
Outdated
"html_options_suspend_screen_capturing_tooltip_line1b": {"message": " как раз перед тем, как она была приостановлена." }, | ||
"html_options_suspend_screen_capturing_tooltip_line2a": {"message": "Функция захвата экрана является экспериментальной и может привести к значительным нагрузке на процессор"}, | ||
"html_options_suspend_screen_capturing_tooltip_line1b": {"message": "как раз перед тем, как она была приостановлена." }, | ||
"html_options_suspend_screen_capturing_tooltip_line2a": {"message": "Функция захвата экрана является экспериментальной и может привести к значительной нагрузке на процессор,"}, | ||
"html_options_suspend_screen_capturing_tooltip_line2b": {"message": "а также повышенное использование памяти." }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"а также к повышенному использованию памяти."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
old version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, but I still would add "к" to ur final version so it'll be like:
"нагрузке на процессор, а также к повышенному потреблению памяти."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
src/_locales/ru/messages.json
Outdated
"html_options_suspend_screen_capturing_tooltip_line2b": {"message": "а также повышенное использование памяти." }, | ||
"html_options_suspend_screen_capturing_tooltip_line3a": { "message": "Если вы заметили странное поведение, например долгая приоставновка вкладки, или Chrome" }, | ||
"html_options_suspend_screen_capturing_tooltip_line3b": { "message": "неожиданно падает, попробуйте отключить эту функцию." }, | ||
"html_options_suspend_screen_capturing_tooltip_line3a": { "message": "Если вы заметили странное поведение, например долгая приоставновка вкладки или" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Если вы заметили странное поведение, например, долгая приостановка вкладки или", comma and "приоставновка"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
old version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, but still missed comma after "например", should be like:
"Если вы заметили странное поведение, например, долгую приостановку вкладки или"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix
src/_locales/ru/messages.json
Outdated
"html_options_suspend_force_screen_capture": { "message": "Включить режим высококачественного захвата экрана" }, | ||
"html_options_suspend_force_screen_capture_tooltip_line1": { "message": "Когда отключено, снимки экрана имеют следующие ограничения для обеспечения производительности:" }, | ||
"html_options_suspend_force_screen_capture_tooltip_line2": {"message": "- Низкое качество захвата экрана"}, | ||
"html_options_suspend_force_screen_capture_tooltip_line4": {"message": "- Не будет отображаться экран, если для генерации изображения требуется более 1 минуты"}, | ||
"html_options_suspend_force_screen_capture_tooltip_line5": {"message": "- Максимальная высота захвата экрана ограничена 5000px"}, | ||
"html_options_suspend_force_screen_capture_tooltip_line6": {"message": "Включение режима высококачественного захвата экрана может значительно увеличить загрузку процессора"}, | ||
"html_options_suspend_force_screen_capture_tooltip_line7": {"message": " и использование памяти." }, | ||
"html_options_suspend_force_screen_capture_tooltip_line7": {"message": "и использование памяти." }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also not sure bout deleted space..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
old version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw ur final variant, it's better, no changes needed in my view 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
src/_locales/ru/messages.json
Outdated
"html_options_suspend_on_low_memory_tooltip_line5": {"message": "указано в параметрах автоматической приостановки табуляции." }, | ||
"html_options_suspend_on_low_memory_tooltip_line6": {"message": "Для получения дополнительной информации об отбрасывании вкладок Chrome см.:"}, | ||
"html_options_other_enable_sync_tooltip_line1a": { "message": "Настройки расширения будут синхронизированы между всеми браузерами Chrome, в которых используется" }, | ||
"html_options_other_enable_sync_tooltip_line1b": { "message": "этот же профиль Chrome." }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Ваш текущий профиль Chrome.", a little "respect" to user with "Ваш" hah, plus not sure about Chrome word repeating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked final version, still think it would be better this way:
"в которых используется Ваш текущий профиль Chrome."
but ur variant also sounds good, so u decide anyway 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe "Настройки расширения будут синхронизированы с Вашим профилем между всеми браузерами Chrome." ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh I like that urs variant, let's keep it 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
"html_options_suspend_on_low_memory_tooltip_line6": {"message": "Для получения дополнительной информации об отбрасывании вкладок Chrome см.:"}, | ||
"html_options_other_enable_sync_tooltip_line1a": { "message": "Настройки расширения будут синхронизированы между всеми браузерами Chrome, в которых используется" }, | ||
"html_options_other_enable_sync_tooltip_line1b": { "message": "этот же профиль Chrome." }, | ||
"html_options_other_enable_sync_tooltip_line2": { "message": "Также синхронизирует настройки в режиме инкогнито." }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Также будут синхронизированы настройки в режиме инкогнито."? not sure here, isn't this sentence like a continuation of a previous?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I consider this phrase superfluous, because with the standard settings in incognito mode, extensions are disabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, they r disabled but dev provided an opportunity to use TGS in Chrome incognito mode, I kinda remember saw him talking about that somewhere here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe "Синхронизирует настройки и в режиме инкогнито." ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm well sounds ok, I guess we may go with it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh but original I still like more:
"Также синхронизирует настройки в режиме инкогнито."
sounds like an addition right away but not like somewhere in the middle of sentence with adding of "и"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in fact "также" == "и" ^_^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does, it's just with "также" at the start of a sentence we naturally understand that this sentence may be an additional information faster, right away when we start reading it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay
src/_locales/ru/messages.json
Outdated
"html_options_other_enable_sync_tooltip_line1a": { "message": "Настройки расширения будут синхронизированы между всеми браузерами Chrome, в которых используется" }, | ||
"html_options_other_enable_sync_tooltip_line1b": { "message": "этот же профиль Chrome." }, | ||
"html_options_other_enable_sync_tooltip_line2": { "message": "Также синхронизирует настройки в режиме инкогнито." }, | ||
"html_options_other_enable_sync_warning": { "message": "Включение этого будет перезаписывать настройки во всех других браузерах, зарегистрированных в этом же профиле Chrome" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Включение этого будет перезаписывать настройки во всех других браузерах, где используется Ваш текущий профиль Chrome", sounds more correct I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With final I see it like this:
"Включение этой опции приведет к перезаписыванию настроек во всех других браузерах Chrome, где используется Ваш текущий профиль Chrome"
Uh this Chrome word repeating sounds weird but it's just seems more correct and accurate this way as well as it is here.. Coz we know there's other Chromium based browsers and for now we can't be sure if settings do sync between for example Chrome and some other Chromium based browser, I guess they're not coz there's no Google..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe "Включение этой опции приведет к перезаписыванию настроек Вашего профиля между всеми браузерами Chrome" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost great, I would just add "расширения для" so we r talking about TGS settings, not whole Chrome profile settings, should sound more correct:
"Включение этой опции приведет к перезаписыванию настроек расширения для Вашего профиля между всеми браузерами Chrome"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect. fixed
src/_locales/ru/messages.json
Outdated
"html_options_suspend_on_low_memory": { "message": "Приостанавливать вкладки при нехватке системной памяти" }, | ||
"html_options_suspend_on_low_memory_tooltip_line1": {"message": "Этот параметр заменяет встроенный в Chrome механизм выгрузки вкладок." }, | ||
"html_options_suspend_on_low_memory_tooltip_line2": {"message": "Если включено, вкладка будет принудительно приостанавливаться, вместо ее выгрузки Chrome." }, | ||
"html_options_suspend_on_low_memory_tooltip_line3": {"message": "Как правило, Chrome выгружает вкладки только когда системной памяти становится очень мало." }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Как правило, Chrome выгружает вкладки только, когда системной памяти становится очень мало.", missed comma
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, she's not needed here.
- только когда
- только тогда, когда
the second option is just longer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Googled more on a topic and I guess according to gramota.ru we both may be not right, comma should be and should be before "только", not after as I suggested, so the final variant will be:
"Как правило, Chrome выгружает вкладки, только когда системной памяти становится очень мало."
comma even if it's against intonation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, really! fixed
src/_locales/ru/messages.json
Outdated
"html_options_suspend_screen_capturing_tooltip_line2a": {"message": "Функция захвата экрана является экспериментальной и может привести к значительной нагрузке на процессор,"}, | ||
"html_options_suspend_screen_capturing_tooltip_line2b": {"message": "а также повышенное использование памяти." }, | ||
"html_options_suspend_screen_capturing_tooltip_line3a": { "message": "Если вы заметили странное поведение, например долгая приоставновка вкладки или" }, | ||
"html_options_suspend_screen_capturing_tooltip_line1a": {"message": "На заблокированной вкладке расширение будет отображать изображение страницы"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"На приостановленной вкладке расширение будет отображать изображение (скриншот) страницы"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Urs final is ok:
"На приостановленной вкладке расширение будет отображать скриншот страницы"
no changes needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
src/_locales/ru/messages.json
Outdated
@@ -118,7 +118,7 @@ | |||
"html_options_other_enable_sync_warning": { "message": "Включение этого будет перезаписывать настройки во всех других браузерах, зарегистрированных в этом же профиле Chrome" }, | |||
"html_options_suspend_on_low_memory": { "message": "Приостанавливать вкладки при нехватке системной памяти" }, | |||
"html_options_suspend_on_low_memory_tooltip_line1": {"message": "Этот параметр заменяет встроенный в Chrome механизм выгрузки вкладок." }, | |||
"html_options_suspend_on_low_memory_tooltip_line2": {"message": "Если включено, вкладка будет принудительно приостанавливаться, вместо ее выгрузки механизмом Chrome." }, | |||
"html_options_suspend_on_low_memory_tooltip_line2": {"message": "Если включено, вкладка будет принудительно приостанавливаться, вместо вместо использования механизма выгрузки Chrome." }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"вместо вместо"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final variant here also correct, no double "вместо":
"Если включено, вкладка будет принудительно приостанавливаться, вместо использования механизма выгрузки Chrome."
no changes needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
@AlexWayfer I agree with ur version in russian, that's what I would offer myself on par with "открыть без приостановки" (open without suspension) but with "загрузить" (load) it sounds more accurate like what exactly will be done if pressed. Also I +1 ur correction for russian export. About original English variant I guess we could ask for developer @deanoemcke's opinion here. |
i fixed "session" buttons |
I agree that the english version should probably change. I like @AlexWayfer suggestion of:
|
@MonsterNya sorry about the misunderstanding. you've discovered a secret untranslated view :) And there is an issue for it too: #856 It currently does NOT include russian translations (although I've used google translate for the chinese and german files). |
Oh, I just noticed it here, sorry. I duplicated this suggestion in the issue about all translations.
I can check, but I don't have enough time for full translation, sorry. |
@AlexWayfer I'm creating pull request there now based on latest dev's English additions, wait a bit |
Thank you very much. |
Are we all happy with merging this PR now? (ignoring those issues handled in other internationalisation branch). |
I guess not yet, but maybe soon |
Alright, created PR here with russian translation for dev's latest English changes, @MonsterNya, @AlexWayfer, @deanoemcke, please review and approve, thank u. |
If it's OK with everyone I'm going to merge this PR now? |
@deanoemcke
|
@MonsterNya the extension explicitly uses the 'system-ui' font which I suppose is different depending on the operating system. I'm not sure how this interacts with chrome or operating system defaults. But whatever we go with, it shouldn't involve changing either of these anyway. I'm not sure the best way to test this. Perhaps you guys will know better than me? @liamjohnston do you have any idea about this? |
in fact, the whole question comes down to one letter "ё", and its use. in the browser, the opera (when writing options) does not use "ё", replacing it with a similar "е". in vivaldi - use. chrome when using search (ctrl + f) considers these letters to be the same. I can not say for sure that this letter will be in all standard fonts of different OS (especially if this extension works on Linux) and browsers. |
I'm on Linux, and everything is OK here with
How often?
Exactly.
Ignoring the unknown probability of errors with system fonts (this is out of extensions responsibility) and write words in the correct way is better for me. I think, the number of people with Russian system language and system font without |
I'm not 100% sure exactly what you guys are talking about. But I would suggest we assume the best case scenario within the extension. That is, that all system fonts will correctly render the ё character. Am I correct in assuming that for those instances when this character is not available, it will fall back to the е character? This seems like an acceptable compromise for those few users that find themselves in this position. And leaves the onus on the OS to improve their character support. I'm not exactly sure what the alternative is that we are proposing here. To not use ё at all, and use е instead? I'd rather we kept the extension language file as accurate as possible, so I'm all for using ё everywhere. But I'm not the most informed to make this decision. I just thought I'd let you know my opinion to help us finish up the awesome work that you guys have all done here :) |
Yep, @deanoemcke is spot on. I've not been following this PR/thread fully but if we're talking about The font stack we use looks good in all operating systems with zero cost (i.e. no loading of web fonts), and I don't think this should change if we can help it. Especially if it's an issue with the font rather than our issue. |
it seems everything is ready, I think we are ready for a merger. |
major changes were made to spelling. however, when translating some terms, it was necessary to deviate from the original, for a better understanding of the essence.
If you have questions, I will try to answer them.