Update tables with new Action Column pattern (Deploy Branch) (#989) #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update Project Enrollment tables * fix a11y * More accessibility fixes * Simplify and resolve todos * Add storybook story * Remove errant comment * Add comments * Update api of TableRowActions * Fix issue with fulColSpan * Right-align table row actions Co-authored-by: Gig <[email protected]> * Remove comment * Replace overrideTableBody with more understandable API * Implement PR suggestion of moving table row to column def * Cleanup and add comments * Port over relevant changes from other PR * Refactor to use renderCellContents * Revert out-of-scope change * Add todo * Remove circular dependency * Clean up * Centralize action column base attrs * PR feedback * Fix typescript problems * Implement Table Actions pattern and default columns (#998) * Implement Table Actions pattern and default columns * Add random comment * Add storybook for table actions and fix cde story * Implement PR suggestion of moving table row to column def * add todo * Finish refactor to use column def instead of getTableAction * Fix bulk services loading * Provide a visually hidden header when header isnt provided * Keep existing behavior of individual/household assessment viewing * Fix typescript * Add accessible text for RelativeDateDisplay * implement one possible approach for client ID typescript * Remove unnecessary cast --------- Co-authored-by: Gig Ashton <[email protected]>
martha
changed the title
|
Converting to draft to avoid early merge |
6 tasks
* Update Project Enrollment tables * fix a11y * More accessibility fixes * Simplify and resolve todos * Add storybook story * Remove errant comment * Add comments * Update api of TableRowActions * Fix issue with fulColSpan * Implement Table Actions pattern and default columns * Add random comment * Add storybook for table actions and fix cde story * Right-align table row actions Co-authored-by: Gig <[email protected]> * Remove comment * Replace overrideTableBody with more understandable API * Implement PR suggestion of moving table row to column def * Implement PR suggestion of moving table row to column def * Cleanup and add comments * add todo * Port over relevant changes from other PR * Refactor to use renderCellContents * Revert out-of-scope change * Add todo * Remove circular dependency * Clean up * Centralize action column base attrs * Finish refactor to use column def instead of getTableAction * Fix bulk services loading * Provide a visually hidden header when header isnt provided * Keep existing behavior of individual/household assessment viewing * PR feedback * Fix typescript problems * Fix typescript * Add accessible text for RelativeDateDisplay * implement one possible approach for client ID typescript * Improve a11y of autofill assessment table * Improve and clean up * PR feedback * Revert unneeded --------- Co-authored-by: Gig Ashton <[email protected]>
* Restore blank cells DataNotCollected relationship * Fix visual and performance bugs with AssignServiceButton * Rename Name to Client Name * Revert the reversion!
* Implement sticky columns in GenericTable * Apply sticky columns to all tables in scope * Mitigate column width issue * Include primary action in secondary action menu * Fix typescript * Keep sx inline? * Make checkbox always sticky * Clarify type signature for sticky styles
|
@martha can you pull 148 into here and deploy it to QA again when you get a chance? thanks 🙏 |
|
actually just realized there is nothing in 148, I can re deploy this |
|
@martha thanks! I am liking this change a lot personally! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please don't merge yet!
This is a deploy branch for https://github.com/open-path/Green-River/issues/6825 and https://github.com/open-path/Green-River/issues/6761, so these features can get plenty of review on QA with design (without being tied to regular releases).
Should merge with warehouse PR to update tests: greenriver/hmis-warehouse#5039
Type of change
Checklist before requesting review