Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HMIS system tests for new Table Action Column pattern #5039

Merged
merged 8 commits into from
Feb 6, 2025
Merged

Update HMIS system tests for new Table Action Column pattern #5039

merged 8 commits into from
Feb 6, 2025

Conversation

martha
Copy link
Contributor

@martha martha commented Jan 7, 2025 •
edited by gigxz
Loading

Merging this PR

Update system tests to match changes from greenriver/hmis-frontend#1020

Issues: https://github.com/open-path/Green-River/issues/6825 and https://github.com/open-path/Green-River/issues/6761.

Type of change

New feature

Checklist before requesting review

  • I have performed a self-review of my code
  • I have run the code that is being changed under ideal conditions, and it doesn't fail
  • [n/a] If adding a new endpoint / exposing data in a new way, I have:
    • ensured the API can't leak data from other data sources
    • ensured this does not introduce N+1s
    • ensured permissions and visibility checks are performed in the right places
  • [n/a] Any major architectural changes are supported by an approved ADR (Architectural Decision Record)
  • I have updated the documentation (or not applicable)
  • I have added spec tests (or not applicable)
  • I have provided testing instructions in this PR or the related issue (or not applicable)

martha and others added 3 commits January 6, 2025 17:07
@martha
Fix erroneous deletion
b514eba
@martha
Revert "Fix erroneous deletion"
fff4369 
This reverts commit b514eba.
@martha @gigxz
Fix spec tests for table actions (#5012)
c14a4f4 
* Fix spec tests

* Correct spec

* Fix spec

* Fix spec tests for table actions

* PR feedback (wip)

* Use aria label directly

* Remove repetition of sys tests

---------

Co-authored-by: Gig <[email protected]>
@martha martha mentioned this pull request Jan 7, 2025
Merged
10 tasks
@martha martha changed the base branch from release-147 to release-149 January 22, 2025 16:58
martha and others added 2 commits January 31, 2025 15:53
@martha @gigxz
Update system tests for Tables (revert changes) (#5071)
a0787be 
* Update system tests (revert changes)

* empty - system tests

---------

Co-authored-by: Gig Ashton <[email protected]>
@gigxz
Merge branch 'release-150' into deploy/6761-table-actions
0d05ac1
@gigxz gigxz changed the base branch from release-149 to release-150 January 31, 2025 21:03
@gigxz gigxz marked this pull request as draft January 31, 2025 21:03
@gigxz gigxz marked this pull request as ready for review February 5, 2025 23:53
@gigxz gigxz changed the base branch from release-150 to release-151 February 6, 2025 12:18
@gigxz gigxz changed the title Update spec tests for new Table Action Column pattern (Deploy Branch) Update spec tests for new Table Action Column pattern Feb 6, 2025
@gigxz gigxz changed the title Update spec tests for new Table Action Column pattern Update HMIS system tests for new Table Action Column pattern Feb 6, 2025
@gigxz gigxz merged commit cf61a7b into release-151 Feb 6, 2025
53 of 54 checks passed
@gigxz gigxz deleted the deploy/6761-table-actions branch February 6, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martha @gigxz