Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize localization function #1350

Closed
1 of 2 tasks
fflorent opened this issue Dec 20, 2024 · 1 comment
Closed
1 of 2 tasks

Sanitize localization function #1350

fflorent opened this issue Dec 20, 2024 · 1 comment
Assignees
@berhalak

Comments

@fflorent
Copy link
Collaborator

Describe the current behavior

Follow-up this conversation:
#1247 (comment)

We cannot trust the localized strings, so we should sanitize them.

Steps to reproduce

No response

Describe the expected behavior

No response

Where have you encountered this bug?

Instance information (when self-hosting only)

  • Grist instance:
    • Version: 1.3.2
@fflorent fflorent mentioned this issue Dec 20, 2024
Merged
4 tasks
@berhalak berhalak mentioned this issue Dec 23, 2024
Merged
@berhalak berhalak mentioned this issue Jan 7, 2025
Merged
4 tasks
@fflorent
Copy link
Collaborator Author

fflorent commented Jan 7, 2025

I close this issue. #1354 does the job, and the follow-up which fixes regressions with docker image builds (#1367) is in good shape and should probably land soon.

@fflorent fflorent closed this as completed Jan 7, 2025
fflorent added a commit to fflorent/grist-core that referenced this issue Jan 7, 2025
@fflorent
Remove the HTML-escaping of translations (now that gristlabs#1350 is …
ece1607 
…fixed)
fflorent added a commit to fflorent/grist-core that referenced this issue Jan 7, 2025
@fflorent
Remove the HTML-escaping of translations (now that gristlabs#1350 is …
c6cb821 
…fixed)
paulfitz pushed a commit that referenced this issue Jan 7, 2025
@berhalak
Failing build if translation files contain invalid values (#1367)
dd6c093 
## Context

Latest PR #1354 was breaking docker build and took the wrong approach for sanitizing translation files. More in the comments. 

## Proposed solution

1. Docker build was fixed by copying translation files sooner (just for validating them).
2. Build now only fails if some translations keys have values with invalid tags. Previously it was fixing them.

## Related issues

#1350
#1354
#1361

## Has this been tested?

<!-- Put an `x` in the box that applies: -->

- [x] 👍 yes, I added tests to the test suite
- [ ] 💭 no, because this PR is a draft and still needs work
- [ ] 🙅 no, because this is not relevant here
- [ ] 🙋 no, because I need help <!-- Detail how we can help you -->
fflorent added a commit to fflorent/grist-core that referenced this issue Jan 8, 2025
@fflorent
Remove the HTML-escaping of translations (now that gristlabs#1350 is …
781aa70 
…fixed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@berhalak berhalak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fflorent @berhalak