-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker build image locales error #1361
Comments
Thanks for the report @tristanrobert. This seems related to a recent merge #1354. cc @berhalak |
tristanrobert
added a commit
to tristanrobert/grist-core
that referenced
this issue
Jan 6, 2025
4 tasks
Oh yes, I see docker builds failing for some time https://github.com/gristlabs/grist-core/actions/workflows/docker_latest.yml |
4 tasks
paulfitz
pushed a commit
that referenced
this issue
Jan 7, 2025
## Context Latest PR #1354 was breaking docker build and took the wrong approach for sanitizing translation files. More in the comments. ## Proposed solution 1. Docker build was fixed by copying translation files sooner (just for validating them). 2. Build now only fails if some translations keys have values with invalid tags. Previously it was fixing them. ## Related issues #1350 #1354 #1361 ## Has this been tested? <!-- Put an `x` in the box that applies: --> - [x] 👍 yes, I added tests to the test suite - [ ] 💭 no, because this PR is a draft and still needs work - [ ] 🙅 no, because this is not relevant here - [ ] 🙋 no, because I need help <!-- Detail how we can help you -->
We're so back. Thanks @tristanrobert @fflorent @berhalak ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the current behavior
docker build -t grist:latest .
exits 1 with error in line 36 in Dockerfile:Line 36 in Dockerfile:
RUN yarn run build:prod
calls buildtools/build.sh which calls sanitize_translations.js which needs/grist/static/locales
which is not copied before.Steps to reproduce
Describe the expected behavior
docker image built
Where have you encountered this bug?
Instance information (when self-hosting only)
Grist instance:
Browser name, version and platforms on which you could reproduce the bug:
Link to browser console log if relevant:
Link to server log if relevant:
The text was updated successfully, but these errors were encountered: