-
-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve database value decoding diagnostics #384
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groue
force-pushed
the
conversionDebugInfo
branch
from
August 3, 2018 06:31
cd87991
to
62b272e
Compare
groue
force-pushed
the
conversionDebugInfo
branch
from
August 6, 2018 11:45
62b272e
to
78a6f72
Compare
…need a single-value container They used to crash on decoding errors
…need a single-value container
- rename ValueConversionDebuggingInfo to ValueConversionContext - allow missing value conversion context (when decoding a raw DatabaseValue) - rename ColumnCursor to FastDatabaseValueCursor - rename NullableColumnCursor to FastNullableDatabaseValueCursor
groue
added a commit
that referenced
this pull request
Aug 13, 2018
…ecords This is the real final touch for #384, after all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes as much information as possible available when a database value conversion error happens:
In the example above, the error message helps understanding that the
Player.name
property should be made optional, or that theplayer.name
database column should be changed so that it never contains null values.And in the following example, it is easy to spot and fix the typo:
With previous GRDB versions, it was sometimes difficult to know which columns or properties would need fixing.