fix(onchange bug): onchange bug (#231)

affects: @gio-design/components, website
growingio · Sep 23, 2020 · 4fcfc9e · 4fcfc9e
1 parent e3b2fd4
commit 4fcfc9e
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/packages/components/src/components/select/Select.tsx b/packages/components/src/components/select/Select.tsx
@@ -112,7 +112,9 @@ const Select: React.FC<SelectProps> = (props: SelectProps) => {
     );
     clearInput();
     if (onChange) {
-      const selectedOptions = Array.from(selection).map((value) => extendedOptions[optionHash.get(value)]);
+      const selectedOptions = Array.from(optSelection).map(
+        (value) => extendedOptions[optionHash.get(value)] || freeInputOption(value)
+      );
       onChange(multiple ? selectedOptions : selectedOptions[0]);
     }
   };

diff --git a/packages/website/src/components/functional/select/demos/multiple.tsx b/packages/website/src/components/functional/select/demos/multiple.tsx
@@ -4,6 +4,6 @@ import '@gio-design/components/es/components/select/style/index.css';
 
 import options from './options';
 
-const Basics = (): React.ReactNode => <Select options={options} multiple width={200} />;
+const Basics = (): React.ReactNode => <Select options={options} multiple width={200} onChange={console.log} />;
 
 export default Basics;
diff --git a/packages/website/src/components/functional/select/demos/search.tsx b/packages/website/src/components/functional/select/demos/search.tsx
@@ -14,9 +14,9 @@ const options = values.map((value, index) => ({
 
 const Basics = (): React.ReactNode => (
   <>
-    <Select options={options} searchable width={200} />
+    <Select options={options} searchable width={200} onChange={console.log} />
     <br />
-    <Select options={options} multiple searchable width={200} />
+    <Select options={options} multiple searchable width={200} onChange={console.log} />
   </>
 );