Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(onchange bug): onchange bug #231

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

zzt1224
Copy link
Collaborator

@zzt1224 zzt1224 commented Sep 17, 2020

affects: @gio-design/components, website

Related issue link

Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

Self check

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

affects: @gio-design/components, website
@zzt1224 zzt1224 added the 🐛 bug Something isn't working label Sep 17, 2020
@zzt1224 zzt1224 requested a review from LEEHONCN September 17, 2020 09:30
@zzt1224 zzt1224 linked an issue Sep 17, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #231 into master will decrease coverage by 0.00%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
- Coverage   62.94%   62.93%   -0.01%     
==========================================
  Files          95       95              
  Lines        2761     2763       +2     
  Branches      682      687       +5     
==========================================
+ Hits         1738     1739       +1     
- Misses       1019     1020       +1     
  Partials        4        4              
Impacted Files Coverage Δ
...ckages/components/src/components/select/Select.tsx 0.00% <0.00%> (ø)
...es/components/src/components/input/InputNumber.tsx 86.66% <66.66%> (ø)
...components/src/components/input/hooks/useEnter.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4779d30...237f925. Read the comment docs.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-231--gio-design.surge.sh

@Danny548326 Danny548326 merged commit 4fcfc9e into growingio:master Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Select] onChange callback error
3 participants