Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The release upload job is broken #981

Closed
johanbrandhorst opened this issue Aug 5, 2019 · 4 comments · Fixed by #982
Closed

The release upload job is broken #981

johanbrandhorst opened this issue Aug 5, 2019 · 4 comments · Fixed by #982
Assignees

Comments

@johanbrandhorst
Copy link
Collaborator

Seems to have been broken between 1.9.2 and 1.9.3. Only found this because I was looking at the releases and didn't see any binaries for the latest one.

Error:

#!/bin/bash -eo pipefail
curl -sL https://git.io/goreleaser | bash


   • releasing using goreleaser 0.113.0...
   • loading config file       file=.goreleaser.yml
   • RUNNING BEFORE HOOKS
   • LOADING ENVIRONMENT VARIABLES
   • GETTING AND VALIDATING GIT STATE
      • releasing v1.9.5, commit ad529a448ba494a88058f9e5be0988713174ac86
   • PARSING TAG      
   • SETTING DEFAULTS 
      • LOADING ENVIRONMENT VARIABLES
      • SNAPSHOTING      
      • GITHUB/GITLAB RELEASES
      • PROJECT NAME     
      • BUILDING BINARIES
   ⨯ release failed after 0.02s error=found 2 items with the ID 'grpc-gateway', please fix your config
Exited with code 1

Note sure yet what this means, I will investigate.

@johanbrandhorst johanbrandhorst self-assigned this Aug 5, 2019
@johanbrandhorst
Copy link
Collaborator Author

Nothing particularly incriminating about the release diff (v1.9.2...v1.9.3), so maybe the problem is goreleaser

@johanbrandhorst
Copy link
Collaborator Author

Looks like the same problem as in goreleaser/goreleaser#1090, which leads me to believe that a new id was introduced, or was all of a sudden depended on, and broke our builds. I will try adding it to the config.

@johanbrandhorst
Copy link
Collaborator Author

Seems to have fixed the issue locally, will submit PR after uploading missing binaries.

@johanbrandhorst
Copy link
Collaborator Author

Releases updated

johanbrandhorst added a commit that referenced this issue Aug 5, 2019
Specify an "id" for each build, as this was otherwise inferred
and duplicate for our two builds.

Also remove the use of the deprecated "archive" instruction
in favour of "archives".

Fixes #981
johanbrandhorst added a commit that referenced this issue Aug 6, 2019
Specify an "id" for each build, as this was otherwise inferred
and duplicate for our two builds.

Also remove the use of the deprecated "archive" instruction
in favour of "archives".

Fixes #981
adasari pushed a commit to adasari/grpc-gateway that referenced this issue Apr 9, 2020
Specify an "id" for each build, as this was otherwise inferred
and duplicate for our two builds.

Also remove the use of the deprecated "archive" instruction
in favour of "archives".

Fixes grpc-ecosystem#981
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant