Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release script #982

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Fix release script #982

merged 1 commit into from
Aug 6, 2019

Conversation

johanbrandhorst
Copy link
Collaborator

Specify an "id" for each build, as this was otherwise inferred
and duplicate for our two builds.

Also remove the use of the deprecated "archive" instruction
in favour of "archives".

Fixes #981

Specify an "id" for each build, as this was otherwise inferred
and duplicate for our two builds.

Also remove the use of the deprecated "archive" instruction
in favour of "archives".

Fixes #981
@johanbrandhorst johanbrandhorst merged commit fdf0635 into master Aug 6, 2019
@codecov-io
Copy link

Codecov Report

Merging #982 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #982   +/-   ##
=======================================
  Coverage   53.25%   53.25%           
=======================================
  Files          40       40           
  Lines        4007     4007           
=======================================
  Hits         2134     2134           
  Misses       1675     1675           
  Partials      198      198

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d63917f...ff81729. Read the comment docs.

@johanbrandhorst johanbrandhorst deleted the fix-release-script branch August 6, 2019 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The release upload job is broken
4 participants