Update SwiftProtobuf to 1.5.0 #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates SwiftProtobuf to 1.5.0, which brings full support for Swift 5. After building/running on this branch, no warnings are emitted with Swift 5 mode.
MrMage
approved these changes
Apr 18, 2019
|
The test failure looks like a flake :-( |
|
Looks like |
|
Updated the timeout to see if this fixes the issue - haven't been able to get the test to fail locally :/ |
|
Looks promising, only one failed this time because of an unknown error. Re-running |
|
See also #441, which unfortunately is still flaky. |
|
Yea I commented on it this morning, looks like it's failing for a different reason there though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates SwiftProtobuf to 1.5.0, which brings full support for Swift 5.
After building/running on this branch, no warnings are emitted with Swift 5 mode.