Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try de-flaking testMultipleConnectivityObserversAreCalled. #441

Merged
merged 3 commits into from
Apr 18, 2019
Merged

Try de-flaking testMultipleConnectivityObserversAreCalled. #441

merged 3 commits into from
Apr 18, 2019

Conversation

MrMage
Copy link
Collaborator

@MrMage MrMage commented Apr 18, 2019

No description provided.

@MrMage MrMage closed this Apr 18, 2019
@MrMage MrMage reopened this Apr 18, 2019
@MrMage MrMage closed this Apr 18, 2019
@MrMage MrMage reopened this Apr 18, 2019
@MrMage MrMage closed this Apr 18, 2019
@MrMage MrMage reopened this Apr 18, 2019
@rebello95
Copy link
Collaborator

Looks like it's failing with:

ServiceServer unexpected error handling method '/echo.Echo/Update': ServerStatus(code: SwiftGRPC.StatusCode.internalError, message: "sending initial metadata failed", trailingMetadata: SwiftGRPC.Metadata)
Fatal error: 'try!' expression unexpectedly raised an error: SwiftGRPC.RPCError.callError(unsuccessful, status unknown): file /Users/travis/build/grpc/grpc-swift/Tests/SwiftGRPCTests/ServerTimeoutTests.swift, line 127

@MrMage MrMage mentioned this pull request Apr 18, 2019
Merged
@rebello95 rebello95 mentioned this pull request Apr 18, 2019
Merged
@rebello95
Copy link
Collaborator

Re-running again to make sure it's still green

@rebello95 rebello95 closed this Apr 18, 2019
@rebello95 rebello95 reopened this Apr 18, 2019
@rebello95
Copy link
Collaborator

Looks good! Thanks for fixing 🙏

@rebello95 rebello95 merged commit c0eca15 into grpc:master Apr 18, 2019
MrMage added a commit that referenced this pull request May 8, 2019
@MrMage
Try de-flaking testMultipleConnectivityObserversAreCalled. (#441)
013e725
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebello95 rebello95 rebello95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrMage @rebello95