Update to SwiftNIO HTTP/2 1.13.0 #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The multiplexer from SwiftNIO HTTP/2 required that the first write on each stream matched the order in which the streams were created. Violating this led to a connection error; all in-flight and subsequent RPCs on that connection would fail. Some of our users noticed this (grpc#912). SwiftNIO HTTP/2 recently reworked the API around how streams are created: HTTP/2 stream channels are no longer created with a stream ID and now deliver the frame payload to the channel pipeline rather than the entire HTTP/2 frame. This allows for a stream ID to be assigned to a stream when it attempts to flush its first write, rather than when the stream is created. Modifications: - Increase the minimum HTTP/2 version to 1.13.0 - Move away from deprecated APIs: this required changing the inbound-in and outbound-out types for `_GRPCClientChannelHandler` as well as a few smaller changes elsewhere. Result: - RPCs can be created concurrently without fear of violating any stream ID ordering rules - Resolves grpc#912
Lukasa
approved these changes
Aug 6, 2020
glbrntt
added a commit
to glbrntt/grpc-swift
that referenced
this pull request
Aug 21, 2020
Motivation: In grpc#922 we adopted some changes from NIO HTTP/2: our handlers now speak in terms of `HTTP2Frame.FramePayload` rather than `HTTP2Frame`. We forgot to update our benchmarks at that time. Modifications: - Speak in `HTTP2Frame.FramePayload`s in embedded client benchmarks - Fix up a couple of typos in benchmark names Result: Benchmarks work.
Merged
Lukasa
pushed a commit
that referenced
this pull request
Aug 24, 2020
Motivation: In #922 we adopted some changes from NIO HTTP/2: our handlers now speak in terms of `HTTP2Frame.FramePayload` rather than `HTTP2Frame`. We forgot to update our benchmarks at that time. Modifications: - Speak in `HTTP2Frame.FramePayload`s in embedded client benchmarks - Fix up a couple of typos in benchmark names Result: Benchmarks work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The multiplexer from SwiftNIO HTTP/2 required that the first write on
each stream matched the order in which the streams were created.
Violating this led to a connection error; all in-flight and subsequent
RPCs on that connection would fail. Some of our users noticed this
(#912). SwiftNIO HTTP/2 recently reworked the API around how streams
are created: HTTP/2 stream channels are no longer created with a stream
ID and now deliver the frame payload to the channel pipeline rather than
the entire HTTP/2 frame. This allows for a stream ID to be assigned to a
stream when it attempts to flush its first write, rather than when the
stream is created.
Modifications:
and outbound-out types for
_GRPCClientChannelHandleras well as afew smaller changes elsewhere.
Result:
ID ordering rules