Fix perf benchmarks #948
Merged
Fix perf benchmarks #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: In grpc#922 we adopted some changes from NIO HTTP/2: our handlers now speak in terms of `HTTP2Frame.FramePayload` rather than `HTTP2Frame`. We forgot to update our benchmarks at that time. Modifications: - Speak in `HTTP2Frame.FramePayload`s in embedded client benchmarks - Fix up a couple of typos in benchmark names Result: Benchmarks work.
Lukasa
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In #922 we adopted some changes from NIO HTTP/2: our handlers now speak
in terms of
HTTP2Frame.FramePayloadrather thanHTTP2Frame. Weforgot to update our benchmarks at that time.
Modifications:
HTTP2Frame.FramePayloads in embedded client benchmarksResult:
Benchmarks work.