Fix TinyIoC for use in dotnetstandard builds #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -361,7 +361,7 @@ public static Type[] SafeGetTypes(this Assembly assembly) | |||
|
|
|||
| #if PORTABLE || NETSTANDARD1_0 || NETSTANDARD1_1 || NETSTANDARD1_2 | |||
| [Flags] | |||
| internal enum BindingFlags { | |||
There was a problem hiding this comment.
BindingFlags was being used in by public methods' arguments
| @@ -4246,7 +4246,7 @@ public static Assembly Assembly(this Type type) | |||
| } | |||
| #endif | |||
| // reverse shim for WinRT SR changes... | |||
| #if (!NETFX_CORE && !PORTABLE && !NETSTANDARD1_0 && !NETSTANDARD1_1 && !NETSTANDARD1_2 && !NETSTANDARD1_3 && !NETSTANDARD1_4 && !NETSTANDARD1_5 || !NETSTANDARD1_6) | |||
There was a problem hiding this comment.
This and the ReverseTypeExtender above were both being compiled in and colliding
|
Thanks for the PR |
gkarabin
pushed a commit
to gkarabin/TinyIoC
that referenced
this pull request
Apr 16, 2020
Fix TinyIoC for use in dotnetstandard builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this duplicates a small bit of the work done by #106 but this was the most minimal change set I could make for a build complete for me when adding TinyIoC.cs to a new .NET Standard 1.0 project.
I may be off base, but I thought this might save someone 5 minutes.