Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TinyIoC for use in dotnetstandard builds #119

Merged
merged 1 commit into from
Aug 18, 2018
Merged

Fix TinyIoC for use in dotnetstandard builds #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/TinyIoC/TinyIoC.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ public static Type[] SafeGetTypes(this Assembly assembly)

#if PORTABLE || NETSTANDARD1_0 || NETSTANDARD1_1 || NETSTANDARD1_2
[Flags]
internal enum BindingFlags {
Copy link
Contributor Author

@alisonaquinas-old alisonaquinas-old Nov 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BindingFlags was being used in by public methods' arguments

public enum BindingFlags {
Default = 0,
IgnoreCase = 1,
DeclaredOnly = 2,
Expand Down Expand Up @@ -4246,7 +4246,7 @@ public static Assembly Assembly(this Type type)
}
#endif
// reverse shim for WinRT SR changes...
#if (!NETFX_CORE && !PORTABLE && !NETSTANDARD1_0 && !NETSTANDARD1_1 && !NETSTANDARD1_2 && !NETSTANDARD1_3 && !NETSTANDARD1_4 && !NETSTANDARD1_5 || !NETSTANDARD1_6)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the ReverseTypeExtender above were both being compiled in and colliding

#if (!NETFX_CORE && !PORTABLE && !NETSTANDARD1_0 && !NETSTANDARD1_1 && !NETSTANDARD1_2 && !NETSTANDARD1_3 && !NETSTANDARD1_4 && !NETSTANDARD1_5 && !NETSTANDARD1_6)
static class ReverseTypeExtender
{
public static bool IsClass(this Type type)
Expand Down