-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Enable pagination for GUAC GraphQL APIs #1525
Comments
The Relay-style pagination seems to be the most recommended and compatible with Apollo and can also be used by REST. Note: ApolloClient can be used to enable caching of the results. The graphQL schema needs to be updated with the following (per noun and verb):
with
With the
Example test implementation for the key/value backend can be found here: https://github.com/guacsec/guac/compare/main...pxp928:artifact-ff:test-pagination-artifact?expand=1 Example implementation with ENT: https://betterprogramming.pub/clean-architecture-with-ent-and-gqlgen-a789933a3665 Other useful docs: |
This is what I was planning to do for pagination too. Initially I thought we might want to define a custom Let's do the right thing and follow the process @pxp928 mentioned above. I think in the long term, |
Based on further discussion, removing |
The only queries that have not been implemented with pagination yet are: |
Closing this as pagination is completed for the queries that need it. |
Is your feature request related to a problem? Please describe.
Pagination as a feature has been brought up multiple times. For example, for data display and also to enable faster queries (i.e. prevent UI stalling).
Describe the solution you'd like
Enable certain queries that may return large amounts of data to allow pagination.
Describe alternatives you've considered
NA
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: