Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Pagination for KeyValue #1901

Closed
wants to merge 6 commits into from
Closed

Include Pagination for KeyValue #1901

wants to merge 6 commits into from

Conversation

nathannaveen
Copy link
Collaborator

@nathannaveen nathannaveen commented May 7, 2024 •
edited by pxp928
Loading

Description of the PR

Included pagination for queries in KeyValue, and fixed the tests.

Part of issue #1525

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@nathannaveen nathannaveen force-pushed the nathan/keyvalue-pagination3 branch 6 times, most recently from 95df0ff to 669b093 Compare May 8, 2024 23:06
@nathannaveen nathannaveen force-pushed the nathan/keyvalue-pagination3 branch 3 times, most recently from 05ac6e5 to 4c37ffe Compare May 9, 2024 19:58
@nathannaveen
Fixed tests
8ddaa04 
Signed-off-by: nathannaveen <[email protected]>
@nathannaveen nathannaveen force-pushed the nathan/keyvalue-pagination3 branch from 4c37ffe to 8ddaa04 Compare May 9, 2024 20:06
@nathannaveen
Copy link
Collaborator Author

Opening PR on a new branch to try fixing e2e

@nathannaveen nathannaveen mentioned this pull request May 10, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac Awaiting requested review from mihaimaruseac mihaimaruseac is a code owner

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nathannaveen