-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Pagination for KeyValue #1904
Include Pagination for KeyValue #1904
Conversation
6795bbd
to
cb890d4
Compare
Signed-off-by: nathannaveen <[email protected]>
Signed-off-by: nathannaveen <[email protected]>
Signed-off-by: nathannaveen <[email protected]>
Signed-off-by: nathannaveen <[email protected]>
Signed-off-by: nathannaveen <[email protected]>
Signed-off-by: nathannaveen <[email protected]>
cb890d4
to
648544a
Compare
648544a
to
28b3dc4
Compare
Signed-off-by: nathannaveen <[email protected]>
28b3dc4
to
4390123
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing next page check when foundOne
is set to true for all the nodes.
Signed-off-by: nathannaveen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTMs. Adding as a comment instead of approval in case we want other reviewers to also look at it. If not, I can approve.
You are good to approve @mihaimaruseac, I just added the others for whoever could review/approve first. |
Thank you @pxp928 for the thorough review and @nathannaveen for a significant amount of work for this PR |
Thank you @mihaimaruseac! |
Description of the PR
Included pagination for queries in KeyValue, and fixed the tests.
Part of issue #1525
Same as #1901
PR Checklist
-s
flag togit commit
.make generate
has been runmake generate
has been runcollectsub
protobuf has been changed,make proto
has been run