Skip to content

Renames Frame->Adornment; changes Frame to have a Border subclass #5724

Renames Frame->Adornment; changes Frame to have a Border subclass

Renames Frame->Adornment; changes Frame to have a Border subclass #5724

Triggered via pull request January 14, 2024 02:13
Status Success
Total duration 4m 0s
Artifacts

dotnet-core.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

13 warnings
build_and_test
The following actions uses node12 which is deprecated and will be forced to run on node16: simon-k/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build_and_test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build_and_test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build_and_test: Terminal.Gui/View/Adornment/Border.cs#L80
The member 'Border.LineStyle' does not hide an accessible member. The new keyword is not required.
build_and_test: Terminal.Gui/Views/GraphView/Annotations.cs#L159
'Border.DrawFrame(Rect, bool)' is obsolete: 'This method is obsolete in v2. Use use LineCanvas or Frame instead.'
build_and_test: Terminal.Gui/Views/TabView.cs#L193
'Border.DrawFrame(Rect, bool)' is obsolete: 'This method is obsolete in v2. Use use LineCanvas or Frame instead.'
build_and_test: Terminal.Gui/View/Layout/ViewLayout.cs#L214
XML comment has a param tag for 'adornment', but there is no parameter by that name
build_and_test: Terminal.Gui/View/Layout/ViewLayout.cs#L217
Parameter 'adornmentType' has no matching param tag in the XML comment for 'View.CreateAdornment(Type)' (but other parameters do)
build_and_test: UICatalog/UICatalog.cs#L102
Possible null reference assignment.
build_and_test: UnitTests/Text/CollectionNavigatorTests.cs#L399
Theory method 'IsCompatibleKey_Does_Not_Allow_Alt_And_Ctrl_Keys' on test class 'CollectionNavigatorTests' has InlineData duplicate(s). Remove redundant attribute(s) from the theory method. (https://xunit.net/xunit.analyzers/rules/xUnit1025)
build_and_test: Terminal.Gui/View/Adornment/Border.cs#L80
The member 'Border.LineStyle' does not hide an accessible member. The new keyword is not required.
build_and_test: Terminal.Gui/Views/GraphView/Annotations.cs#L159
'Border.DrawFrame(Rect, bool)' is obsolete: 'This method is obsolete in v2. Use use LineCanvas or Frame instead.'
build_and_test: Terminal.Gui/Views/TabView.cs#L193
'Border.DrawFrame(Rect, bool)' is obsolete: 'This method is obsolete in v2. Use use LineCanvas or Frame instead.'