-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2489. New ScrollSlider
, Scroll
, and ScrollBar
- Adds IScrolLBar
so any View can have scrollbars
#3811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweaks and suggestions
Suggestions and questions
…erformance in the Position property.
…nal.Gui into BDisp-v2_2489_scroll-scrollbar-new
Updated CharMap.
Tweaked `CharMap` based on your latest
… into BDisp-v2_2489_scroll-tig-builtin
More Charmap scrollbar tweaks
… into BDisp-v2_2489_scroll-tig-builtin
Scroll related API doc and conceptual overview improvements
… into BDisp-v2_2489_scroll-scrollbar-new
Closed
15 tasks
9 tasks
23 tasks
Replaced with #3820 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on @BDisp's awesome work in #3498 and #3798.
Fixes
ScrollBar
based on a newScroll
and removeScrollBarView/ScrollView
#2489Proposed Changes/Todos
ScrollSlider
Scroll
to haveContentPosition
andSliderPosition
++ScrollBar
to be based onScroll
and just useButton
CharMap
to use the newScrollbar
and demonstrate: Content area with headers, full keyboard integration, scrolling with > 1 increments (horizontal - 3 columns per).Scroll
andScrollBar
scenariosAllViewsTester
so it can test scrollbarsScrolling
ScearnioContentScrolling
scenarioHorizontalScrollbar
/VerticalScrollbar
out ofView
and intoIScrollBar
/IScrollbarIHelper
classesScrollView
andScrollBarView
Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)