Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2489. New ScrollSlider and ScrollBar - Any View can have scrollbars easily #3820

Merged
merged 164 commits into from
Nov 19, 2024

Conversation

tig
Copy link
Collaborator

@tig tig commented Nov 13, 2024

This is based on @BDisp's awesome work in #3498 and #3798. Supplants #3811.

Fixes

Proposed Changes/Todos

  • Port @BDisp's work to Fixes #3761, #2886, #3780, #3485, #3622, #3413, #2995 - Draw and Layout performance/correctness #3798.
  • Polish ScrollSlider
  • Update Scroll to have ContentPosition and SliderPosition ++
  • Update ScrollBar to be based on Scroll and just useButton
  • Update unit tests
  • Rebuild CharMap to use the new Scrollbar and demonstrate: Content area with headers, full keyboard integration, scrolling with > 1 increments (horizontal - 3 columns per).
  • Update Scroll and ScrollBar scenarios
  • Fix AllViewsTester so it can test scrollbars
  • Update Scrolling Scearnio
  • Update ContentScrolling scenario
  • Update View.ScrollBar.cs to be cleaner
  • Remove ScrollView and ScrollBarView
  • Remove REPONDER!!!!
  • Fix scenarios that used to use ScrollView
  • Update HexView to use

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

BDisp and others added 30 commits May 23, 2024 22:42
…nal.Gui into BDisp-v2_2489_scroll-scrollbar-new
@tig tig marked this pull request as ready for review November 18, 2024 17:14
@tig tig requested review from BDisp, tznind and dodexahedron November 18, 2024 17:23
@tig tig changed the title Fixes #2489. New ScrollSlider, Scroll, and ScrollBar - Adds IScrolLBar so any View can have scrollbars Fixes #2489. New ScrollSlider and ScrollBar - Any View can have scrollbars easily Nov 18, 2024
@tig
Copy link
Collaborator Author

tig commented Nov 18, 2024

This is ready for review!

Please read ./docfx/docs/scrolling.md first.

Reviewing the diff for HexView.cs and HexEditor.cs will really illustrate the new API and how much simpler things are now.

@tig
Copy link
Collaborator Author

tig commented Nov 19, 2024

Thanks for reviewing @BDisp.

Any quesitons?

@tig tig merged commit 4664481 into gui-cs:v2_develop Nov 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants