Ignore file with generated blake2b hashes #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit 122f1b0, we started generating the blake2b checksums of all files in a package to a file in the plan's directory. We should ignore this. Signed-off-by: jtimberman <[email protected]>
|
So will this generate these files in everybody's plan directory on different repos? Seems kind of impolite; could we store them somewhere less obtrusive or clean up after ourselves?
|
|
📌 Commit 47263c3 has been approved by |
|
@jtimberman The right solution here is to write that file into |
thesentinels
pushed a commit
that referenced
this pull request
Jun 10, 2016
In commit 122f1b0, we started generating the blake2b checksums of all files in a package to a file in the plan's directory. We should ignore this. Signed-off-by: jtimberman <[email protected]> Pull request: #725 Approved by: smith
|
☀️ Test successful - travis |
|
@fnichol absolutely, are you gonna tend that that fix or should @jtimberman? |
|
I can pick this up if no fixes come in before I start rebuilding |
|
I've got this |
fnichol
added a commit
that referenced
this pull request
Jun 11, 2016
This change addresses 2 issues: * The file that contains the cryptographic hashes to be stored in the `FILES` metadata file needs to be created under the source cache, not in the `$PLAN_CONTEXT` directory. * The `$HAB_BIN` variable must be used throughout the program and not the `$_hab_cmd` variable, who's role has been downplayed. References #725 Signed-off-by: Fletcher Nichol <[email protected]>
fnichol
added a commit
that referenced
this pull request
Jun 11, 2016
This change addresses 2 issues: * The file that contains the cryptographic hashes to be stored in the `FILES` metadata file needs to be created under the source cache, not in the `$PLAN_CONTEXT` directory. * The `$HAB_BIN` variable must be used throughout the program and not the `$_hab_cmd` variable, who's role has been downplayed. References #725 Signed-off-by: Fletcher Nichol <[email protected]>
thesentinels
pushed a commit
that referenced
this pull request
Jun 11, 2016
This change addresses 2 issues: * The file that contains the cryptographic hashes to be stored in the `FILES` metadata file needs to be created under the source cache, not in the `$PLAN_CONTEXT` directory. * The `$HAB_BIN` variable must be used throughout the program and not the `$_hab_cmd` variable, who's role has been downplayed. References #725 Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #743 Approved by: fnichol
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
In commit 122f1b0, we started generating the blake2b checksums of all files in a package to a file in the plan's directory. We should ignore this. Signed-off-by: jtimberman <[email protected]> Pull request: #725 Approved by: smith
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
This change addresses 2 issues: * The file that contains the cryptographic hashes to be stored in the `FILES` metadata file needs to be created under the source cache, not in the `$PLAN_CONTEXT` directory. * The `$HAB_BIN` variable must be used throughout the program and not the `$_hab_cmd` variable, who's role has been downplayed. References #725 Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #743 Approved by: fnichol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 122f1b0, we started generating the blake2b checksums of all files in a package to a file in the plan's directory. We should ignore this.
Signed-off-by: jtimberman [email protected]