Build-a-rama, June 2016 Edition #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1703723. Signed-off-by: Fletcher Nichol <[email protected]>
This change adds the `core/unzip` package to the dependencies for `core/hab-plan-build` (i.e. the "build" program) with the result that `unzip` will be present on `$PATH` for Plan authors. Adding a new dependency to the build toolchain also meant updating the base build set. Additionally, as `core/bash-static` and `core/coreutils-static` are no longer in the build toolchain critical path (from the retirement of `hab-bpm`), these were dropped from the base build set. Closes #591 Signed-off-by: Fletcher Nichol <[email protected]>
This will add `vi` onto a Plan author's `$PATH` if they are in an interactive Studio. Signed-off-by: Fletcher Nichol <[email protected]>
This change fixes a mismatch argument value in the `hab pkg hash` subcommand (`TARGET` vs. `SOURCE`). Aditionally, the subcommand ordering the `cli.rs` and `main.rs` were re-sorted in order to make the fake fuzzy matching code easier to manage and to facilitate side-by-side viewing of the 2 source files. Finally, the auth token parsing/lookup logic was refactored into a function, similar to the origin parsing/lookup logic. This refactoring adds an `auth_token` configuration value that can be set in a user's `etc/cli.toml` configuration file. A later change may add an additional question to the `hab cli setup` in order to populate this automatically. Signed-off-by: Fletcher Nichol <[email protected]>
Signed-off-by: Fletcher Nichol <[email protected]>
This change addresses 2 issues: * The file that contains the cryptographic hashes to be stored in the `FILES` metadata file needs to be created under the source cache, not in the `$PLAN_CONTEXT` directory. * The `$HAB_BIN` variable must be used throughout the program and not the `$_hab_cmd` variable, who's role has been downplayed. References #725 Signed-off-by: Fletcher Nichol <[email protected]>
fnichol
force-pushed
the
fnichol/build-a-rama-june-2016-edition
branch
from
9a9f746 to
1fd452d
Compare
| @@ -33,6 +33,9 @@ do_build() { | |||
| do_install() { | |||
| do_default_install | |||
|
|
|||
| # Add a `vi` which symlinks to `vim` | |||
| ln -sv vim $pkg_prefix/bin/vi | |||
fnichol
changed the title
|
📌 Commit 1fd452d has been approved by |
thesentinels
pushed a commit
that referenced
this pull request
Jun 11, 2016
This reverts commit 1703723. Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #743 Approved by: fnichol
thesentinels
pushed a commit
that referenced
this pull request
Jun 11, 2016
This change adds the `core/unzip` package to the dependencies for `core/hab-plan-build` (i.e. the "build" program) with the result that `unzip` will be present on `$PATH` for Plan authors. Adding a new dependency to the build toolchain also meant updating the base build set. Additionally, as `core/bash-static` and `core/coreutils-static` are no longer in the build toolchain critical path (from the retirement of `hab-bpm`), these were dropped from the base build set. Closes #591 Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #743 Approved by: fnichol
thesentinels
pushed a commit
that referenced
this pull request
Jun 11, 2016
This will add `vi` onto a Plan author's `$PATH` if they are in an interactive Studio. Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #743 Approved by: fnichol
thesentinels
pushed a commit
that referenced
this pull request
Jun 11, 2016
This change fixes a mismatch argument value in the `hab pkg hash` subcommand (`TARGET` vs. `SOURCE`). Aditionally, the subcommand ordering the `cli.rs` and `main.rs` were re-sorted in order to make the fake fuzzy matching code easier to manage and to facilitate side-by-side viewing of the 2 source files. Finally, the auth token parsing/lookup logic was refactored into a function, similar to the origin parsing/lookup logic. This refactoring adds an `auth_token` configuration value that can be set in a user's `etc/cli.toml` configuration file. A later change may add an additional question to the `hab cli setup` in order to populate this automatically. Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #743 Approved by: fnichol
thesentinels
pushed a commit
that referenced
this pull request
Jun 11, 2016
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #743 Approved by: fnichol
thesentinels
pushed a commit
that referenced
this pull request
Jun 11, 2016
This change addresses 2 issues: * The file that contains the cryptographic hashes to be stored in the `FILES` metadata file needs to be created under the source cache, not in the `$PLAN_CONTEXT` directory. * The `$HAB_BIN` variable must be used throughout the program and not the `$_hab_cmd` variable, who's role has been downplayed. References #725 Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #743 Approved by: fnichol
|
☀️ Test successful - travis |
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
This reverts commit 1703723. Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #743 Approved by: fnichol
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
This change adds the `core/unzip` package to the dependencies for `core/hab-plan-build` (i.e. the "build" program) with the result that `unzip` will be present on `$PATH` for Plan authors. Adding a new dependency to the build toolchain also meant updating the base build set. Additionally, as `core/bash-static` and `core/coreutils-static` are no longer in the build toolchain critical path (from the retirement of `hab-bpm`), these were dropped from the base build set. Closes #591 Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #743 Approved by: fnichol
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
This will add `vi` onto a Plan author's `$PATH` if they are in an interactive Studio. Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #743 Approved by: fnichol
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
This change fixes a mismatch argument value in the `hab pkg hash` subcommand (`TARGET` vs. `SOURCE`). Aditionally, the subcommand ordering the `cli.rs` and `main.rs` were re-sorted in order to make the fake fuzzy matching code easier to manage and to facilitate side-by-side viewing of the 2 source files. Finally, the auth token parsing/lookup logic was refactored into a function, similar to the origin parsing/lookup logic. This refactoring adds an `auth_token` configuration value that can be set in a user's `etc/cli.toml` configuration file. A later change may add an additional question to the `hab cli setup` in order to populate this automatically. Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #743 Approved by: fnichol
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #743 Approved by: fnichol
jtimberman
pushed a commit
that referenced
this pull request
Jun 12, 2016
This change addresses 2 issues: * The file that contains the cryptographic hashes to be stored in the `FILES` metadata file needs to be created under the source cache, not in the `$PLAN_CONTEXT` directory. * The `$HAB_BIN` variable must be used throughout the program and not the `$_hab_cmd` variable, who's role has been downplayed. References #725 Signed-off-by: Fletcher Nichol <[email protected]> Pull request: #743 Approved by: fnichol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.