Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adds ant plan #881

Closed
wants to merge 7 commits into from
Closed

[WIP] Adds ant plan #881

wants to merge 7 commits into from

Conversation

spuder
Copy link

@spuder spuder commented Jun 16, 2016

No description provided.

@thesentinels
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @adamhjk to be a potential reviewer

@spuder spuder changed the title Adds ant plan [WIP]: Adds ant plan Jun 16, 2016
@spuder spuder changed the title [WIP]: Adds ant plan Adds ant plan Jun 16, 2016
@smith
Copy link
Contributor

smith commented Jun 16, 2016

@spuder is this a work in progress? Building the plan did not install ant for me. It looks like the do_build and do_install callbacks don't do anything and I end up with an empty package.

@spuder
Copy link
Author

spuder commented Jun 16, 2016

I should have put WIP in the description. It needs more validation.

Ant shouldnt require compilation since it is a jar.

@jtimberman jtimberman changed the title Adds ant plan [WIP] Adds ant plan Jun 17, 2016
@jtimberman
Copy link
Contributor

I put WIP on the title so folks know 😁

@spuder
Copy link
Author

spuder commented Jun 17, 2016

I've resolved the empty artifact.

This works, however it is still not getting JAVA_HOME set correctly. I don't understand habitat environment variables enough yet to know how to fix it.

hab studio -k foobar enter
build
hab pkg install /src/results/foo-bar-1.0.0.-xxxxx.hart
hab pkg exec core/ant ant
Error: JAVA_HOME is not defined correctly.
  We cannot execute java

Update

I wonder if this is actually be a problem with the java packages since java gives me the error 'no such file or directory'.

hab pkg install core/server-jre
hab pkg exec core/server-jre java -version
✗✗✗
✗✗✗ `java' was not found on the filesystem or in PATH
✗✗✗

hab pkg exec core/server-jre jre/bin/java -version
✗✗✗
✗✗✗ `java' was not found on the filesystem or in PATH
✗✗✗
hab pkg install core/jdk8
hab pkg exec core/jdk8 java -version
✗✗✗
✗✗✗ `java' was not found on the filesystem or in PATH
✗✗✗

hab pkg install core/jdk8
hab pkg exec core/jdk8 jre/bin/java -version
✗✗✗
✗✗✗ `java' was not found on the filesystem or in PATH
✗✗✗
[12][default:/src:1]# JAVA_HOME=$(hab pkg path core/server-jre) hab pkg exe spuder/ant ant
/hab/pkgs/spuder/ant/1.9.7/20160617233831/bin/ant: line 338: /hab/pkgs/core/server-jre/8u92/20160612150143/jre/bin/java: No such file or directory

[13][default:/src:127]# JAVA_HOME=$(hab pkg path core/jdk8) hab pkg exe spuder/ant ant
/hab/pkgs/spuder/ant/1.9.7/20160617233831/bin/ant: line 338: /hab/pkgs/core/jdk8/8u92/20160617191958/jre/bin/java: No such file or directory

Adds mkdir since cp is now in `do_build` instead of `do_install`
@cullenmcdermott cullenmcdermott mentioned this pull request Jun 18, 2016
@smith
Copy link
Contributor

smith commented Jun 21, 2016

Closing in favor of #919. Thanks for the work on this one!

@smith smith closed this Jun 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants