add ant plan #919
add ant plan #919
Conversation
|
By analyzing the blame information on this pull request, we identified @adamhjk to be a potential reviewer |
|
|
||
| do_build() { | ||
| export JAVA_HOME=$(hab pkg path core/jdk8) | ||
| ln -s $(hab pkg path core/glibc)/lib/ld-2.22.so /lib/ld-linux-x86-64.so.2 |
There was a problem hiding this comment.
this should probably be a patchelf rather than a symlink
There was a problem hiding this comment.
I've update the PR to use a patchelf instead of a symlink
cullenmcdermott
force-pushed
the
add_ant_plan
branch
from
e96ad2f to
db1f379
Compare
| pkg_license=('Apache 2') | ||
| pkg_source=https://github.com/apache/ant/archive/rel/$pkg_version.tar.gz | ||
| pkg_shasum=53dbfb13e0e9bf1b34bcbfdf807c1b9df1b89362b176e1e58150906f518b2c88 | ||
| pkg_deps=() |
There was a problem hiding this comment.
this will need a runtime dep of core/jdk8
|
@cullenmcdermott looks good, I was able to start Ant after adding it would be great to have a README.md that mentions: The same could be added to |
|
@cullenmcdermott I added a Maven plan: #928 which builds with Ant. |
| pkg_name=ant | ||
| pkg_version=1.9.7 | ||
| pkg_maintainer='The Habitat Maintainers <[email protected]>' | ||
| pkg_license=('Apache 2') |
There was a problem hiding this comment.
can you change the license string to read Apache-2.0, per the SPDX License List?
|
@metadave How are you starting ant? When I run the pkg, I get the following error.
curl https://raw.githubusercontent.com/cullenmcdermott/habitat-1/451481a5753ecb7b2a1cdadb16c0520201420e70/plans/ant/plan.sh > plan.sh
hab studio -k spuder enter
[0][default:/src:0]# build
...
[2][default:/src:0]# export JAVA_HOME=$(hab pkg path core/jdk8)
[3][default:/src:0]# hab pkg exec spuder/ant ant
/hab/pkgs/spuder/ant/1.9.7/20160621172825/bin/ant: line 85: uname: command not found
/hab/pkgs/spuder/ant/1.9.7/20160621172825/bin/ant: line 102: basename: command not found
/hab/pkgs/spuder/ant/1.9.7/20160621172825/bin/ant: line 115: dirname: command not found
Error: Could not find or load main class org.apache.tools.ant.launch.Launcher |
|
@spuder my bad, I built via The solution is to change add |
|
Indeed adding Looking forward to core/ant being released. (metadave/ant still has the coreutils problem). |
|
@spuder metadave/ant was just a test build, I don't intend to release artifacts in that origin. However, I've pushed a build just in case someone stumbles upon it. |
|
@cullenmcdermott great, ready for us to merge? |
|
Yeah! |
|
📌 Commit d9af99a has been approved by |
|
⌛ Testing commit d9af99a with merge d6b4aed... |
Pull request: #919 Approved by: metadave
Pull request: #919 Approved by: metadave
Pull request: #919 Approved by: metadave
Pull request: #919 Approved by: metadave
|
thanks @cullenmcdermott built and pushed to the depot: https://app.habitat.sh/#/pkgs/core/ant/1.9.7/20160621210022 |
|
☀️ Test successful - travis |
I saw that #881 already existed, I'm fine with whichever one the maintainers want to take. I'm having trouble installing this package with
hab pkg installdue to theCrypto error: No public or secret keys found for name_with_revso I haven't been able to fully test it but I am able to use it to compile a Cassandra artifact if I build this first.