Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated spell checker to ignore member's names #7073

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Updated spell checker to ignore member's names #7073

merged 1 commit into from
Jul 8, 2024

Conversation

vanessasinam
Copy link
Member

Fixes #7010

What changes did you make?

  • Updated the code spell check configuration file so the spell checker excludes lines matching "- name:".

Why did you make the changes (we will use this info to test)?

  • So that the spell checker can avoid checking lines with " - name:" to reduce the number of false positives ("unknown word") in the spell check.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to website

@github-actions GitHub Actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b vanessasinam-update-spell-check-7010 gh-pages
git pull https://github.com/vanessasinam/website.git update-spell-check-7010

mSharifHub
mSharifHub previously requested changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@mSharifHub mSharifHub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just before approving, json does not support comments. on line 4 // words - list of words to be always considered correct should be removed.

@vanessasinam
Copy link
Member Author

Just before approving, json does not support comments. on line 4 // words - list of words to be always considered correct should be removed.

Hi, the comments on line 4 were not part of my changes.

@vanessasinam vanessasinam requested a review from mSharifHub June 28, 2024 16:25
@t-will-gillis t-will-gillis requested a review from mrodz June 30, 2024 17:13
@mrodz
Copy link
Member

mrodz commented Jul 1, 2024

ETA EOD 7/2/24.
Availability: TWThFSSn (I am camping on Monday and early Tuesday)

mrodz
mrodz approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@mrodz mrodz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Correct to/from branches
  • Correct PR formatting
  • Good description of changes
  • The regex you provided looks correct to me—good on you for including the $ to ensure the pattern ends after the name.

    Before

    image

    After

    image

Regarding @mSharifHub's observation, the comment has been in the file since its creation (015736e). Many JSON parsers handle comments even though they are not in spec, which is why this is not a problem. Additionally, dealing with this comment is not in the scope of this issue.

Good stuff! Keep up the good work.

@t-will-gillis t-will-gillis self-requested a review July 8, 2024 02:54
@t-will-gillis
Copy link
Member

available: 7/7
eta: 7/7 eod

t-will-gillis
t-will-gillis approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vanessasinam Great work! All of the basics are in place: branches are good, linked to orig. issue, concise description of what was done and why, and code edits are clean.

CSpell is ignoring - name: <someone> in all of the .md files per the issue requirements. Thanks for taking care of this issue and eliminating dozens of false positives from the spell checker.

@t-will-gillis t-will-gillis dismissed mSharifHub’s stale review July 8, 2024 03:14

Line 4 is not part of this issue, and CSpell does not appear to be affected by it

@t-will-gillis t-will-gillis merged commit 3bdfccf into hackforla:gh-pages Jul 8, 2024
6 checks passed
@t-will-gillis t-will-gillis mentioned this pull request Jul 8, 2024
Closed
6 tasks
terrencejihoonjung pushed a commit to terrencejihoonjung/website that referenced this pull request Jul 13, 2024
@vanessasinam @terrencejihoonjung
Updated spell checker to ignore memebers names (hackforla#7073)
248bff2
t-will-gillis added a commit that referenced this pull request Aug 18, 2024
@terrencejihoonjung @HackforLABot
@dcotelessa @santisecco @t-will-gillis @jennisung @williamzhang73 @melissam640 @alabador @DakuwoN @Kle012 @cchrizzle @duojet2ez @mrodz @DrAcula27 @vanessasinam @aadilahmed
Update Team Meeting Data on Events Page to show Meeting Frequency (#7088
5cb891d 
)

* updated-team-meeting-data-6920

* Update contributor and language data

* Update contributor and language data

* Fix Capitalization of "Slack" in CONTRIBUTING.MD - line 582 (#7038)

* Update contributor and language data

* Modified spell-check-audit.md file, changed label Feature: Administrative to feature: spelling (#7036)

* PBB migration "Issue Trigger"  (#7053)

* Update issue-trigger.yml

Changes in prep for Projects Beta migration

* Update issue-trigger.yml

space added to comment

* Update issue-trigger.yml

edits to comment at Team Members

* Update preliminary-update-comment.js

refactoring for PBB migration

* PBB migration "Pull Request Trigger" (#7054)

* Update pull-request-trigger.yml

edits for PBB migration

* Update pull-request-trigger.yml

remove test branch

* PBB migration "Schedule Friday" (#7055)

* Update schedule-fri-0700.yml

Changes for PBB migration

* Update add-label.js

* Update find-linked-issue.js

For PBB migration

* Update add-label.js

remove refs to personal repo

* Update add-label.js

addressing CodeQL alert

* Update add-label.js

address CodeQL alert

* PBB migration "Move Closed Issues" (#7056)

* Update move-closed-issues.yaml

for migration to PBB

* Update sort-closed-issues.js

* Add github-handle for Roland Abregorivas in heart.md #6940 (#7009)

* github-handle variable added for Gian Reyes Dionisio #6937 (#6984)

* Update contributor and language data

* updated role for Will Gillis on website project profile (#7063)

* Add github handle for Marie (#7059)

* added github handle element for Tien Yuan in heart.md (#7069)

* Update contributor and language data

* Fixes #7046 Added github handle to _projects/heart.md for Jason LaManque.

* Update Roslyn's role to Developer Co-Lead (#7070)

* img Tag Refactor in Contributing.md page  (#7068)

* Update contributor and language data

* Added github-handle to Adrian Inchauste's section (#7074)

* Update contributor and language data

* edited Samantha Hyler to be Co-lead AND added Emma Thrash (#7040)

* 6786 remove bop from untaggedrepoids in get project datajs (#7062)

* remove references to BoP's id from the `untaggedRepoIds` list

* Update contributor and language data

* Revert `github.repository` post GHA test

* Resolve merge conflicts

* Resolve merge conflicts (p2)

---------

Co-authored-by: GitHub Actions Bot <[email protected]>

* Update CONTRIBUTING.md Section 2.7.d with correct stream branch (#7082)

* Update meeting data

* Update contributor and language data

* Update Inactive Members JSON

* Revert "updated-team-meeting-data-6920 (#7043)" (#7086)

This reverts commit dc11c65.

* Update contributor and language data

* Update contributor and language data

* updated team meeting data on events page to show meeting frequency

* Add 'Leadership Option' to Issue Template for CoP Information Update (#7077)

* add leadership type option with dropdown fields

* remove whitespace between labels and body

* remove whitespace in title

* remove whitespace in front of the yes/no options

* change default type

* Update contributor and language data

* Updated spell checker to ignore memebers names (#7073)

* Update contributor and language data

* Update contributor and language data

* truncate contributors name in filter tag with ellipis (#7052)

* Update contributor and language data

---------

Co-authored-by: GitHub Actions Bot <[email protected]>
Co-authored-by: David Cotelessa <[email protected]>
Co-authored-by: Santiago Secco <[email protected]>
Co-authored-by: Will Gillis <[email protected]>
Co-authored-by: Jennifer Sung <[email protected]>
Co-authored-by: williamzhang <[email protected]>
Co-authored-by: Melissa McGrath <[email protected]>
Co-authored-by: Austin Labador <[email protected]>
Co-authored-by: Matthew McCane <[email protected]>
Co-authored-by: Kim <[email protected]>
Co-authored-by: Christopher Chang <[email protected]>
Co-authored-by: duojet2ez <[email protected]>
Co-authored-by: Mateo Rodriguez <[email protected]>
Co-authored-by: Danielle Andrews <[email protected]>
Co-authored-by: vanessasinam <[email protected]>
Co-authored-by: Aadil Ahmed <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrodz mrodz mrodz approved these changes

@t-will-gillis t-will-gillis t-will-gillis approved these changes

@mSharifHub mSharifHub Awaiting requested review from mSharifHub

Assignees
No one assigned
Labels
Complexity: Medium feature: spelling role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update spell check config file to ignore members' names
4 participants
@vanessasinam @mrodz @t-will-gillis @mSharifHub