Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Team Meeting Data on Events Page to show Meeting Frequency #7088

Merged
merged 41 commits into from
Aug 18, 2024
Merged

Update Team Meeting Data on Events Page to show Meeting Frequency #7088

merged 41 commits into from
Aug 18, 2024

Conversation

terrencejihoonjung
Copy link
Member

Fixes #6920

What changes did you make?

  • added *This meeting is not weekly, check project link for more details. at the bottom of the right-col-content.html
  • conditionally rendered an asterisk if the event's description was not empty within right-col-content.js

Why did you make the changes (we will use this info to test)?

  • to indicate that an asterisk means that the meeting is not necessarily weekly
  • when the event description is not empty, it contains information about an alternative meeting schedule. By rendering an asterisk when the event description is not empty, we indicate that the meeting is not weekly.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied before
Visuals after changes are applied after

terrencejihoonjung and others added 30 commits June 20, 2024 19:46
@terrencejihoonjung
updated-team-meeting-data-6920
b664698
@HackforLABot @terrencejihoonjung
Update contributor and language data
9bca4d0
@HackforLABot @terrencejihoonjung
Update contributor and language data
bbe37cc
@dcotelessa @terrencejihoonjung
Fix Capitalization of "Slack" in CONTRIBUTING.MD - line 582 (hackforl…
c74316a 
…a#7038)
@HackforLABot @terrencejihoonjung
Update contributor and language data
326927f
@santisecco @terrencejihoonjung
Modified spell-check-audit.md file, changed label Feature: Administra…
17f5b38 
…tive to feature: spelling (hackforla#7036)
@t-will-gillis @terrencejihoonjung
PBB migration "Issue Trigger" (hackforla#7053)
34f7d80 
* Update issue-trigger.yml

Changes in prep for Projects Beta migration

* Update issue-trigger.yml

space added to comment

* Update issue-trigger.yml

edits to comment at Team Members

* Update preliminary-update-comment.js

refactoring for PBB migration
@t-will-gillis @terrencejihoonjung
PBB migration "Pull Request Trigger" (hackforla#7054)
75e686f 
* Update pull-request-trigger.yml

edits for PBB migration

* Update pull-request-trigger.yml

remove test branch
@t-will-gillis @terrencejihoonjung
PBB migration "Schedule Friday" (hackforla#7055)
815bde9 
* Update schedule-fri-0700.yml

Changes for PBB migration

* Update add-label.js

* Update find-linked-issue.js

For PBB migration

* Update add-label.js

remove refs to personal repo

* Update add-label.js

addressing CodeQL alert

* Update add-label.js

address CodeQL alert
@t-will-gillis @terrencejihoonjung
PBB migration "Move Closed Issues" (hackforla#7056)
69e70f8 
* Update move-closed-issues.yaml

for migration to PBB

* Update sort-closed-issues.js
@jennisung @terrencejihoonjung
Add github-handle for Roland Abregorivas in heart.md hackforla#6940 (h…
4cc4eb9 
…ackforla#7009)
@williamzhang73 @terrencejihoonjung
github-handle variable added for Gian Reyes Dionisio hackforla#6937 (h…
a151951 
…ackforla#6984)
@HackforLABot @terrencejihoonjung
Update contributor and language data
f9f1c92
@melissam640 @terrencejihoonjung
updated role for Will Gillis on website project profile (hackforla#7063)
e8f1c06
@alabador @terrencejihoonjung
Add github handle for Marie (hackforla#7059)
43b7024
@melissam640 @terrencejihoonjung
added github handle element for Tien Yuan in heart.md (hackforla#7069)
89fa866
@HackforLABot @terrencejihoonjung
Update contributor and language data
9d0b687
@DakuwoN @terrencejihoonjung
Fixes hackforla#7046 Added github handle to _projects/heart.md for Ja…
7094b44 
…son LaManque.
@alabador @terrencejihoonjung
Update Roslyn's role to Developer Co-Lead (hackforla#7070)
d18fe5e
@Kle012 @terrencejihoonjung
img Tag Refactor in Contributing.md page (hackforla#7068)
6abb020
@HackforLABot @terrencejihoonjung
Update contributor and language data
f909481
@cchrizzle @terrencejihoonjung
Added github-handle to Adrian Inchauste's section (hackforla#7074)
53351b0
@HackforLABot @terrencejihoonjung
Update contributor and language data
0046646
@duojet2ez @terrencejihoonjung
edited Samantha Hyler to be Co-lead AND added Emma Thrash (hackforla#…
c16b957 
…7040)
@mrodz @HackforLABot @terrencejihoonjung
6786 remove bop from untaggedrepoids in get project datajs (hackforla…
a625a7d 
…#7062)

* remove references to BoP's id from the `untaggedRepoIds` list

* Update contributor and language data

* Revert `github.repository` post GHA test

* Resolve merge conflicts

* Resolve merge conflicts (p2)

---------

Co-authored-by: GitHub Actions Bot <[email protected]>
@dcotelessa @terrencejihoonjung
Update CONTRIBUTING.md Section 2.7.d with correct stream branch (hack…
a225870 
…forla#7082)
@HackforLABot @terrencejihoonjung
Update meeting data
48b889d
@HackforLABot @terrencejihoonjung
Update contributor and language data
4260913
@HackforLABot @terrencejihoonjung
Update Inactive Members JSON
c2a7622
@t-will-gillis @terrencejihoonjung
Revert "updated-team-meeting-data-6920 (hackforla#7043)" (hackforla#7086
c7be9d6 
)

This reverts commit dc11c65.
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b terrencejihoonjung-update-team-meeting-data-6920 gh-pages
git pull https://github.com/terrencejihoonjung/website.git update-team-meeting-data-6920

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/terrencejihoonjung/website/blob/update-team-meeting-data-6920/CONTRIBUTING.md

@github-actions github-actions bot added role: front end Tasks for front end developers Complexity: Medium P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Events https://www.hackforla.org/events/ P-Feature: Project Meetings https://www.hackforla.org/project-meetings size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jul 5, 2024
@ha-bach ha-bach self-requested a review July 7, 2024 17:01
@ha-bach
Copy link
Member

ha-bach commented Jul 7, 2024

Review ETA: end of day.
Availability: Sunday, Monday, Wednesday.

ha-bach
ha-bach suggested changes Jul 7, 2024
View reviewed changes
Copy link
Member

@ha-bach ha-bach left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @terrencejihoonjung,

  • branching looks good
  • relevant linked issue
  • code edit is clean
  • correct changes showed up on my test page

Issues to address:

  • merge conflict with current version of website at _data/external/github-data.json

Overall great work! Just one file is outdated from the current website. Once you've fixed the merge conflict, feel free to @ me and I will review the PR again.

@Thinking-Panda Thinking-Panda self-requested a review July 10, 2024 20:15
@terrencejihoonjung
Copy link
Member Author

Hi @muninnhugin,

Thank you for your feedback! I've handled the merge conflict and updated my branch.

Thank you!

ha-bach
ha-bach approved these changes Jul 13, 2024
View reviewed changes
Copy link
Member

@ha-bach ha-bach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, thank you for your contribution!

@jphamtv
Copy link
Member

jphamtv commented Aug 8, 2024

Hi @Thinking-Panda - Please add your ETA and availability for this review when you get a chance. Thanks!

@t-will-gillis t-will-gillis self-requested a review August 18, 2024 03:34
t-will-gillis
t-will-gillis approved these changes Aug 18, 2024
View reviewed changes
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @terrencejihoonjung I am able to load this in Docker and cross check with vrms-data.json to see that whenever a meeting lists a description, an * is rendered on the "Events" page.

Great job, and thanks for taking care of this.

@t-will-gillis t-will-gillis merged commit 5cb891d into hackforla:gh-pages Aug 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-will-gillis t-will-gillis t-will-gillis approved these changes

@ha-bach ha-bach ha-bach approved these changes

@Thinking-Panda Thinking-Panda Awaiting requested review from Thinking-Panda

Assignees
No one assigned
Labels
Complexity: Medium P-Feature: Events https://www.hackforla.org/events/ P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) P-Feature: Project Meetings https://www.hackforla.org/project-meetings role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Team Meeting data on the Events page to show meeting frequency