Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added github-handle property for Andrew Salvatore #7293

Merged

Conversation

saiteja-siddana
Copy link
Member

Fixes #7246

What changes did you make?

  • I modified _projects/tech-work-experience.md by adding 'github-handle' key below the 'name: Andrew Salvatore' key/value pair.

Why did you make the changes (we will use this info to test)?

  • This change is intended to reduce redundancy in the project file by replacing 'github' and 'picture' key/value pairs.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No visual changes to the website. The new key is not part of a display card.

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b saiteja-siddana-add-github-handle-7246 gh-pages
git pull https://github.com/saiteja-siddana/website.git add-github-handle-7246

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 15, 2024
@Anahisv23 Anahisv23 self-requested a review August 15, 2024 17:12
@Anahisv23
Copy link
Member

ETA: EOD

Copy link
Member

@Anahisv23 Anahisv23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @saiteja-siddana, thank you for working on this issue. Everything looks good on my end. Nice work!

What went well

  • Into and from branch are set up correctly
  • PR explains what you changed and why you changed it
  • PR is linked to the correct issue number
  • Appropriate lines of code were changed to add the github-handle variable

@t-will-gillis t-will-gillis requested a review from 8alpreet August 18, 2024 17:04
@8alpreet
Copy link
Member

8alpreet commented Aug 19, 2024

Review ETA: EOD
Availability: Mon to Fri; 3 p.m. to 7 p.m.

Copy link
Member

@8alpreet 8alpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @saiteja-siddana,

What went well:

  • Into and from branch are set up correctly
  • PR explains what you changed and why you changed it
  • PR is linked to the correct issue number
  • Only relevant lines of code were changed to add the github-handle variable

Additional feedback

  • I love the details ("property" and name of team member) you provided in the PR title
  • The use of specific language such a "key" and "value" demonstrates your understanding of the changes and builds a shared context with the reviewer

@roslynwythe roslynwythe merged commit c725a7e into hackforla:gh-pages Aug 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

Successfully merging this pull request may close these issues.

Add github-handle for Andrew Salvatore in tech-work-experience.md
4 participants