-
-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added github-handle property for Andrew Salvatore #7293
Added github-handle property for Andrew Salvatore #7293
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
ETA: EOD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @saiteja-siddana, thank you for working on this issue. Everything looks good on my end. Nice work!
What went well
- Into and from branch are set up correctly
- PR explains what you changed and why you changed it
- PR is linked to the correct issue number
- Appropriate lines of code were changed to add the
github-handle
variable
Review ETA: EOD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @saiteja-siddana,
What went well:
- Into and from branch are set up correctly
- PR explains what you changed and why you changed it
- PR is linked to the correct issue number
- Only relevant lines of code were changed to add the github-handle variable
Additional feedback
- I love the details ("property" and name of team member) you provided in the PR title
- The use of specific language such a "key" and "value" demonstrates your understanding of the changes and builds a shared context with the reviewer
Fixes #7246
What changes did you make?
_projects/tech-work-experience.md
by adding 'github-handle' key below the 'name: Andrew Salvatore' key/value pair.Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)