Added github-handle for Farah Khan in home-unite-us.md

[codyyjxn]

Fixes #7185

What changes did you make?

• I updated the _projects/home-unite-us.md file by inserting a new key, 'github-handle,' directly beneath the 'name: Farah Khan'

Why did you make the changes (we will use this info to test)?

• I made this change to streamline the project file by introducing a 'github-handle' key, which replaces the need for separate 'github' and 'picture' entries.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

• No screenshots since adding a variable did not create any new visual change

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

---

From your project repository, check out a new branch and test the changes.

git checkout -b codyyjxn-add-githandle-7185 gh-pages
git pull https://github.com/codyyjxn/website.git add-githandle-7185

[8alpreet]

Review ETA: EOD Tue Aug 20
Availability: Mon to Fri; 3 p.m. to 7 p.m.

[codyyjxn]

I have closed the other pr that I first set but now I have created the new pr with the write commits and the issue that I was assigned to do.

[santisecco]

Review ETA: 2 PM 8/20/24
Availability: 8-3 PM Tuesday 8/20/24

[santisecco]

Hi @codyyjxn thanks for working on this!

Branches are correct, no visual changes and the code was correctly modified, with the right spacing.

Great job!

[codyyjxn]

Thank you! Can I work on another issue ?

[8alpreet]

Hi @codyyjxn,

What went well:

• Into branch is set up correctly.
• PR is linked to the correct issue number.
• Branch is named correctly
• Only relevant lines of code were changed.
• You answered the "What.." section well

Changes needed:

1. "Why.." section:
   • I am confused by the "Update related logic and documentation" portion of your words. What is the related logic and documentation being updated?
   • The rest of your description regarding use of github handle and project consistency is fine.
   • this section should almost be a short summary of the issue.
   • after reading it, I should quickly know why the issue was created thus why this PR was created.

[codyyjxn]

@8alpreet
Thank you for your feedback. I've implemented the changes as suggested and revised the context accordingly. Please review it and let me know if there are any areas that could be further clarified. I'm open to making adjustments to ensure everything is as clear as possible.

[8alpreet]

Thank you! Can I work on another issue ?

We can only work on one issue at a time. This one must be merged before you can move on.

[8alpreet]

Hi, I appreciate you being open to feedback and making changes! Your updated "Why.." section is more like the "What.." section now because you're describing what you did.

Imagine their is a future issue where users are accidentally clicking delete instead of save. Let's say your solution to the problem, meaning your what, is to make the Save button green and to make/keep the Delete button gray. Your reasoning for the change (green is associated with good/save; green draws attention more than grey) would go into the why section.

I know the differences in this GFI aren't as obvious and it seems unnecessary to practically restate what the issue itself says.

I encourage you to give it another shot, but you can consult the following PR if you're unsure or stuck: LINK.

[santisecco]

I must say I missed paying attention to the sections "What changes did you make?" and "Why did you make the changes (we will use this info to test)?".

As @8alpreet mentions the idea behind this questions is to give a brief summary of what was done and the reasons for why the changes were made.

I would add the following, the "What section" would be clearer if you stated what was done and omitted "has been successfully" or other further descriptions involving a sort of "examination" of what was done. That would be eventually determined by the reviewer and merge team.

It's better to be more concise I believe. We are all here to learn. Me myself made the mistake of not reading carefully the description of what was done.

But still your code was clear and the change was done correctly.

[codyyjxn]

@santisecco
Thank you for your feedback. I've implemented the changes as suggested and revised the context accordingly. Please review it and let me know if there are any areas that could be further clarified. I'm open to making adjustments to ensure everything is as clear as possible.

[8alpreet]

Everything looks great now. You did a great job applying the feedback!

[roslynwythe]

@santisecco @santisecco please re-review this PR. Thank you

[codyyjxn]

@Satenik-Ba please re-review this PR. Thank you

[santisecco]

Hi @codyyjxn thank you very much!
Your description of the "what" is very precise and clear.
The changes are great

[codyyjxn]

Thank you! 👍🏼

…

On Wed, Aug 21, 2024 at 5:42 AM Santi Vidal ***@***.***> wrote: ***@***.**** approved this pull request. Hi @codyyjxn <https://github.com/codyyjxn> thank you very much! Your description of the "what" is very precise and clear. The changes are great — Reply to this email directly, view it on GitHub <#7320 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BGV5I3GFHSATEWCQHFSFPJDZSSDLVAVCNFSM6AAAAABMYZSL6GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENJQGY4TKNRQHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>