Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhantomJS plugin for PDF printing doesn't work in relesease 3.4.0+ #1815

Closed
asanzdiego opened this issue Feb 4, 2017 · 4 comments
Closed

PhantomJS plugin for PDF printing doesn't work in relesease 3.4.0+ #1815

asanzdiego opened this issue Feb 4, 2017 · 4 comments

Comments

@asanzdiego
Copy link

Hi:

The PhantomJS plugin of @manuelbieh for PDF printing doesn't work in relesease 3.4.0+

Thanks for all.
hakimel added a commit that referenced this issue Feb 15, 2017
@hakimel
new phantom pdf export script that works with 3.4.0 #1815
a349ff4
@hakimel
Copy link
Owner

hakimel commented Feb 15, 2017

I've rewritten the script to work with 3.4.0. The updated script will preload the presentation and read the configured width/height from reveal.js directly so that we can use that as the PDF page size. This makes it work with any configured size and removes the old "width" and "height" arguments from the phantom script.

@hakimel hakimel closed this as completed Feb 15, 2017
@asanzdiego
Copy link
Author

Thanks @hakimel. I will try the last relase ¿3.4.2? in my own proyect MarkDownSlides \o/

@hakimel
Copy link
Owner

hakimel commented Feb 15, 2017

No problem. There's no new release yet, but the updated script is available in master.

@asanzdiego
Copy link
Author

I've tested it and it seems to work fine. :) But I can't upgrade my proyect until you do a release :( Thanks a lot anyway \o/

benswift added a commit to benswift/reveal.js that referenced this issue Apr 4, 2017
@benswift
Merge remote-tracking branch 'hakimel-gh/master'
7d08de9 
* hakimel-gh/master:
  new phantom pdf export script that works with 3.4.0 hakimel#1815
  updated pdf docs
  update readme re: pdf exports hakimel#1823
  Update README.md to include block for pdf printing
  Update README.md
  3.4.1
  adjust pdf margins instead of heights to fix hakimel#1804
  additional fix for empty pages in pdf exports hakimel#1804
  fix empty pages in pdf exports (closes hakimel#1804)
  correct grunt option usage
  For a fragment: allow to show a separate note defined in it
derheap pushed a commit to derheap/reveal.js that referenced this issue Feb 22, 2018
@hakimel
new phantom pdf export script that works with 3.4.0 hakimel#1815
b7e0d2b
R0bes pushed a commit to R0bes/Terraform-Presentation that referenced this issue Jun 7, 2021
@hakimel
new phantom pdf export script that works with 3.4.0 hakimel#1815
3e7d3f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hakimel @asanzdiego