Remove conflict with Char in dart:ffi
#349
Assignees
Comments
|
@dcharkes This is fixed in win32 v2.3.8. |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this issue
Mar 28, 2022
The diff from https://dart-review.googlesource.com/c/sdk/+/229156/1..3 This was blocked by halildurmus/win32#349 earlier. Now that that has been resolved, we should be able to land this. We should land this to make package:ffigen be able to bind to `char` in Dart 2.17. dart-archive/ffigen#287 (comment) TEST=tests/ffi/c_types_test.dart Change-Id: Ia3bc3785a3d5c0c9f7475106eb77f944f2d0a838 Cq-Include-Trybots: luci.dart.try:vm-kernel-linux-debug-ia32-try,vm-kernel-win-debug-ia32-try,vm-kernel-nnbd-mac-debug-arm64-try,vm-kernel-nnbd-mac-debug-x64-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64c-try,vm-precomp-ffi-qemu-linux-release-arm-try,vm-precomp-ffi-qemu-linux-release-riscv64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239020 Auto-Submit: Daco Harkes <[email protected]> Reviewed-by: Jens Johansen <[email protected]> Reviewed-by: Martin Kustermann <[email protected]>
|
Can we close this issue ? |
|
It's closed, no? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
https://dart-review.googlesource.com/c/sdk/+/228541 added a
Chartype todart:ffi.Unfortunately that breaks
package:win32and in turn the Flutter build: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8824468064587445729/+/u/Android_Views_Integration_Tests/stdoutThe easiest fix would be to just
import 'dart:ffi' hide Char;in https://github.com/timsneath/win32/blob/main/lib/src/structs.g.dart.(And then release a new version, and roll that into Flutter, and any packages that are used in Flutter and roll those into Flutter.)
The text was updated successfully, but these errors were encountered: