Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Char in preparation for new package:ffi #362

Closed
wants to merge 1 commit into from

Conversation

Sunbreak
Copy link
Contributor

@Sunbreak Sunbreak commented Feb 9, 2022

Signed-off-by: Sunbreak [email protected]

@Sunbreak
Copy link
Contributor Author

Sunbreak commented Feb 9, 2022

Since https://pub.dev/packages/ffi/versions/1.2.0-dev.0 Char is inside package:ffi according to dart-archive/ffi#128

Related issue: #349

@timsneath
Copy link
Contributor

This would have been a great patch, but we actually decided to not ship Char in package:ffi and then move it to dart:ffi. We discovered we were causing a lot of name clashes, so we retracted 1.2.0 and are going to just ship the new Char data type in dart:ffi itself in Dart 2.17.0.

As you note, this continues to cause a name clash for the prerelease version, but there are obviously no guarantees that prerelease code is bug-free. I may change the upper bound of win32's dependency on package:ffi to avoid version 1.2.0-dev.0, but even that doesn't solve for people who already have existing versions.

@dcharkes should we retract 1.2.0-dev.0 as well as 1.2.0, just for completeness? I also saw this isolated incident in the Flutter issue database.

@dcharkes
Copy link

dcharkes commented Feb 9, 2022

@dcharkes should we retract 1.2.0-dev.0 as well as 1.2.0, just for completeness?

ffigen's dev release depends on it, and people are experimenting with it and finding bugs. So, I'd say no.

I also saw this isolated incident in the Flutter issue database.

Pub should never select pre-releases by itself. So maybe the bug reported upgraded his project right in the time 1.2.0 stable was live?

@timsneath
Copy link
Contributor

These types have landed in 2.17 (not yet released to stable), and they have been renamed to UnsignedChar and SignedChar, which solves the problem of name clashes altogether. See https://api.dart.dev/be/184424/dart-ffi/dart-ffi-library.html.

As a result, I'm closing this PR -- hope that's OK?

@timsneath timsneath closed this Mar 20, 2022
@Sunbreak Sunbreak deleted the patch-1 branch March 20, 2022 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants