-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show the startup status of the plugin #5520
feat: show the startup status of the plugin #5520
Conversation
Signed-off-by: Ryan Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5520 +/- ##
============================================
- Coverage 56.91% 56.29% -0.62%
- Complexity 3319 3324 +5
============================================
Files 587 600 +13
Lines 18968 19665 +697
Branches 1401 1360 -41
============================================
+ Hits 10795 11070 +275
- Misses 7594 8031 +437
+ Partials 579 564 -15 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议提供一个呼吸 Dot 即可,不用显示文字。如果一定要显示,也建议把鼠标放上去后再显示。
Dot 的颜色会和后面的未绑定应用市场的 Dot 难以区分,如果不显示文字建议使用 loading 状态显示可能会好点 |
/ping @ruibaby |
我是觉得这个 StatusDot 组件提供的 default 状态不是特别明显,所以添加了文字,因为它不属于异常,所以也不太合适用 warning 或者 error。 |
Signed-off-by: Ryan Wang <[email protected]>
Quality Gate passedIssues Measures |
我这边测试发现,看不到启动中的状态,状态一闪而过。 |
目前只有在插件启动耗时长的情况下才会显示启动状态。比如创建索引。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#### What type of PR is this? /area ui /kind bug /milestone 2.15.0 #### What this PR does / why we need it: 修复插件异常启动时,指示器显示不正确的问题。 Fixes #5520 #### Does this PR introduce a user-facing change? ```release-note None ```
What type of PR is this?
/area ui
/kind feature
/milestone 2.14.x
What this PR does / why we need it:
Show the startup status of the plugin
Which issue(s) this PR fixes:
Fixes #5254
Does this PR introduce a user-facing change?