Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show plugin error message #5838

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Apr 30, 2024

What type of PR is this?

/area ui
/kind bug
/milestone 2.15.0

What this PR does / why we need it:

修复插件异常启动时,指示器显示不正确的问题。

Fixes #5520

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 30, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.15.0 milestone Apr 30, 2024
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. labels Apr 30, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added lgtm Indicates that a PR is ready to be merged. labels Apr 30, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.54%. Comparing base (5fdf6c0) to head (e2c817f).
Report is 156 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5838      +/-   ##
============================================
- Coverage     56.91%   56.54%   -0.37%     
- Complexity     3319     3443     +124     
============================================
  Files           587      612      +25     
  Lines         18968    20333    +1365     
  Branches       1401     1396       -5     
============================================
+ Hits          10795    11497     +702     
- Misses         7594     8262     +668     
+ Partials        579      574       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

/approve

Copy link

f2c-ci-robot bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 2178bd8 into halo-dev:main Apr 30, 2024
8 checks passed
@ruibaby ruibaby deleted the fix/plugin-error-tip branch April 30, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants