refactor: enhance cache management in plugin setting config #6141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
kind/feature
f2c-ci-robot
bot
added
the
area/plugin
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6141 +/- ##
============================================
- Coverage 56.91% 55.08% -1.83%
- Complexity 3319 3501 +182
============================================
Files 587 636 +49
Lines 18968 21456 +2488
Branches 1401 1501 +100
============================================
+ Hits 10795 11819 +1024
- Misses 7594 9029 +1435
- Partials 579 608 +29 ☔ View full report in Codecov by Sentry. |
JohnNiang
reviewed
Jun 26, 2024
application/src/main/java/run/halo/app/plugin/DefaultReactiveSettingFetcher.java
Outdated
Show resolved
Hide resolved
application/src/main/java/run/halo/app/plugin/DefaultPluginApplicationContextFactory.java
Show resolved
Hide resolved
application/src/main/java/run/halo/app/plugin/SharedApplicationContextFactory.java
Outdated
Show resolved
Hide resolved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
f2c-ci-robot bot
pushed a commit
that referenced
this pull request
Jun 26, 2024
…plugin (#6156) #### What type of PR is this? /kind bug /area core /area plugin #### What this PR does / why we need it: The problem was introduced by PR <#6141>. That PR wrongly registered `settingFetcher` singleton bean. #### Which issue(s) this PR fixes: <img width="1920" alt="image" src="https://github.com/halo-dev/halo/assets/16865714/ecc67064-3506-49b8-8114-a145da549126"> #### Does this PR introduce a user-facing change? ```release-note None ```
f2c-ci-robot bot
pushed a commit
to halo-dev/docs
that referenced
this pull request
Jun 28, 2024
### What this PR does? 新增关于如何使用插件配置的文档 see also halo-dev/halo#6141 ```release-note None ```
f2c-ci-robot bot
pushed a commit
that referenced
this pull request
Jun 30, 2024
) #### What type of PR is this? /kind bug /area core /area plugin /milestone 2.17.x #### What this PR does / why we need it: This PR makes sure the method `cache#put` is called before the event is published to avoid the event listener to fetch the old value from the cache. The problem was introduced by <#6141>. #### Which issue(s) this PR fixes: Fixes #6213 #### Does this PR introduce a user-facing change? ```release-note 修复在插件配置变更监听器中始终获取到旧数据的问题 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/area plugin
/area core
/milestone 2.17.x
What this PR does / why we need it:
增强插件配置的缓存管理
PluginConfigUpdatedEvent事件来做一些处理，它会在用户更改插件配置后被触发Does this PR introduce a user-facing change?