-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the problem of not being able to autowire settingFetcher bean in plugin #6156
Fix the problem of not being able to autowire settingFetcher bean in plugin #6156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…plugin Signed-off-by: JohnNiang <[email protected]>
778c1c2
to
bde459d
Compare
New changes are detected. LGTM label has been removed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6156 +/- ##
============================================
+ Coverage 54.51% 56.98% +2.47%
- Complexity 3523 3706 +183
============================================
Files 646 652 +6
Lines 21862 22038 +176
Branches 1528 1537 +9
============================================
+ Hits 11917 12559 +642
+ Misses 9328 8874 -454
+ Partials 617 605 -12 ☔ View full report in Codecov by Sentry. |
What type of PR is this?
/kind bug
/area core
/area plugin
What this PR does / why we need it:
The problem was introduced by PR #6141. That PR wrongly registered
settingFetcher
singleton bean.Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?