-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add before and after security web filters #6297
Add before and after security web filters #6297
Conversation
Signed-off-by: JohnNiang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6297 +/- ##
============================================
+ Coverage 54.51% 58.28% +3.77%
- Complexity 3523 3763 +240
============================================
Files 646 647 +1
Lines 21862 21967 +105
Branches 1528 1541 +13
============================================
+ Hits 11917 12804 +887
+ Misses 9328 8545 -783
- Partials 617 618 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/kind api-change
/area core
/area plugin
What this PR does / why we need it:
This PR adds
BeforeSecurityWebFilter
andAfterSecurityWebFilter
extension points. See halo-sigs/plugin-page-cache#4 (comment) for more.Now, we can do something before and after authenticating.
Does this PR introduce a user-facing change?