Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

缓存策略问题 #4

Closed
ruibaby opened this issue Jul 9, 2024 · 2 comments
Closed

缓存策略问题 #4

ruibaby opened this issue Jul 9, 2024 · 2 comments

Comments

@ruibaby
Copy link
Member

ruibaby commented Jul 9, 2024

已知目前的缓存判断或者策略问题：

  1. 根据需求，登录用户访问页面不会经过缓存，也不会缓存页面结果。但目前可能存在登录用户也会缓存结果，这可能造成访客最终访问的网页是登录用户缓存的结果。
  2. 已登录用户首次打开网页，可能会经过缓存。
@JohnNiang
Copy link
Contributor

经过排查，目前在 AdditionalWebFilter 中无法知晓当前用户的登录状态。通过 WebSession 获取登录状态的方式不完全正确，尤其是关闭浏览器后重新进入页面的时候，因为登录时用户选择了“记住我”，所以此时获取 WebSession 实际上为空，自动登录逻辑发生在 Security Filter Chain 上，并不在 PageCacheWebFilter 之前。

我这里提供一种方案：类似于这里提到的 WebFilter，我们再提供一种在认证之前和之后的 WebFilter 扩展点。这样我们就可以肥肠方便且可靠地获取当前用户的认证情况。

@JohnNiang JohnNiang mentioned this issue Jul 9, 2024
Merged
f2c-ci-robot bot pushed a commit to halo-dev/halo that referenced this issue Jul 9, 2024
@JohnNiang
Add before and after security web filters (#6297)
9cdd8a5 
#### What type of PR is this?

/kind feature
/kind api-change
/area core
/area plugin

#### What this PR does / why we need it:

This PR adds `BeforeSecurityWebFilter` and `AfterSecurityWebFilter` extension points. See halo-sigs/plugin-page-cache#4 (comment) for more.

Now, we can do something before and after authenticating.

#### Does this PR introduce a user-facing change?

```release-note
添加认证授权的前置和后置处理器扩展点
```
@ruibaby
Copy link
Member Author

ruibaby commented Aug 1, 2024

已经在 halo-dev/halo#6297 中修复。

/close

@ruibaby ruibaby closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JohnNiang @ruibaby