Fix the problem that roles could not be granted sometimes #6471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JohnNiang <[email protected]>
f2c-ci-robot
bot
added
release-note
Signed-off-by: JohnNiang <[email protected]>
Signed-off-by: JohnNiang <[email protected]>
Signed-off-by: JohnNiang <[email protected]>
JohnNiang
force-pushed
the
refactor/searching-roles
branch
from
2725829 to
9fe02f6
Compare
|
/retitle Fix the problem that roles could not be granted sometimes |
f2c-ci-robot
bot
changed the title
f2c-ci-robot
bot
removed
the
do-not-merge/work-in-progress
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6471 +/- ##
============================================
- Coverage 58.27% 58.16% -0.12%
+ Complexity 3783 3762 -21
============================================
Files 651 650 -1
Lines 22139 22106 -33
Branches 1555 1537 -18
============================================
- Hits 12902 12857 -45
- Misses 8613 8639 +26
+ Partials 624 610 -14 ☔ View full report in Codecov by Sentry. |
JohnNiang
changed the title
f2c-ci-robot
bot
added
the
do-not-merge/work-in-progress
Signed-off-by: JohnNiang <[email protected]>
Signed-off-by: JohnNiang <[email protected]>
JohnNiang
changed the title
f2c-ci-robot
bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: JohnNiang <[email protected]>
|
f2c-ci-robot
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot bot
pushed a commit
that referenced
this pull request
Aug 27, 2024
…#6530) #### What type of PR is this? /kind bug /area core /milestone 2.19.0 #### What this PR does / why we need it: This PR corrects list options builder for listing aggregated roles, because I wrongly used the label selector in <#6471>. #### Special notes for your reviewer: 1. Try to install the plugin <https://www.halo.run/store/apps/app-YXyaD> 2. Enable the plugin and enable setting `匿名评论需要验证码` 3. **Anonymous** request any of posts with comment enabled 4. Check the captcha in comment area #### Does this PR introduce a user-facing change? ```release-note 修复可能无法正常访问插件提供的接口的问题 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
/area core
What this PR does / why we need it:
This PR refactors searching roles by using index mechanism to speed up every request and fix the problem of not being able to grant roles to users sometimes.
Which issue(s) this PR fixes:
Fixes #5807
Fixes #4954
Fixes #5057
Does this PR introduce a user-facing change?