Fix the incorrect list options builder while listing aggregated roles #6530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JohnNiang <[email protected]>
f2c-ci-robot
bot
added
kind/bug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6530 +/- ##
============================================
- Coverage 58.18% 57.83% -0.36%
- Complexity 3774 3865 +91
============================================
Files 651 668 +17
Lines 22125 22840 +715
Branches 1538 1584 +46
============================================
+ Hits 12873 13209 +336
- Misses 8641 9010 +369
- Partials 611 621 +10 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/area core
/milestone 2.19.0
What this PR does / why we need it:
This PR corrects list options builder for listing aggregated roles, because I wrongly used the label selector in #6471.
Special notes for your reviewer:
匿名评论需要验证码Does this PR introduce a user-facing change?