-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: enhance formkit select component to support additional features #6473
refactor: enhance formkit select component to support additional features #6473
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6473 +/- ##
============================================
+ Coverage 58.18% 58.41% +0.23%
- Complexity 3774 3800 +26
============================================
Files 651 652 +1
Lines 22125 22247 +122
Branches 1538 1545 +7
============================================
+ Hits 12873 12996 +123
+ Misses 8641 8637 -4
- Partials 611 614 +3 ☔ View full report in Codecov by Sentry. |
8c97b81
to
d15a51e
Compare
…-auto-complete-formkit
/hold |
…-auto-complete-formkit
/unhold |
…-auto-complete-formkit
4f4998a
to
f79a34e
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#### What type of PR is this? /kind improvement /area ui /milestone 2.19.x #### What this PR does / why we need it: 使用 #6473 中重构的 Formkit Select 组件来实现用户、文章、页面等各种业务搜索组件。 Fixes #4931 #### How to test it? 测试各类搜索组件是否正常可用。 测试从旧版本升级后,原有数据是否可以正常显示。 #### Does this PR introduce a user-facing change? ```release-note 使用重构的 Formkit Select 组件来实现业务选择器。 ```
What type of PR is this?
/kind feature
/area ui
/milestone 2.19.x
What this PR does / why we need it:
此 PR 使用自定义的 Select 组件替换了原有的 Formkit Select 组件,原 Select 组件类型变为
nativeSelect
。新的 Select 组件具有如下功能:
重构后的 Select 组件将自动兼容旧版组件。
使用方式如下:
How to test it?
测试在多选、单选状态下,Select 组件的功能是否可以正常使用。
测试在远程加载时,数据获取是否正常,是否可正常分页,加载状态是否显示。
Which issue(s) this PR fixes:
see #4931 (comment)
see #6369
Does this PR introduce a user-facing change?